실패하는 테스트 코드 주석 처리 #31
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
1jeongg
commented
Oct 2, 2023
1jeongg
commented
- 이미지 저장 경로 문제로 석준님 로컬에서만 통과하는 테스트 코드를 주석 처리했습니다(이후 PR시 원활한 Github CI 사용을 위해..)
- readme 파일에 팀원 소개를 추가하고 카카오에서 만들어준 default README 내용을 토글로 변경했습니다.
- 현재 포트폴리오 이미지가 로컬에 올라가서 테스트 실패가 난다 - 실패하는 테스트가 있는 코드를 merge시키면 이후 PR때마다 Github CI가 모두 실패했다고 뜰 것이므로 이를 주석처리함
This comment was marked as duplicate.
This comment was marked as duplicate.
Sorry, something went wrong.
seokwns
approved these changes
Oct 2, 2023
|
아닙니다! 하는김에 Readme도 추가하고 잔디도 심고... 오히려 좋습니다~ 😄 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.