-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
리뷰 이미지 조회 로직 수정 #193
리뷰 이미지 조회 로직 수정 #193
Conversation
- 리뷰 이미지 조회 로직 수정 - plannerid로 조회 -> review ids로 조회 - lazy loading 하지 않도록 미리 fetch join 하도록 수정
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
고생하셨습니다
@@ -71,17 +71,21 @@ public void addReview(User user, Long chatId, ReviewRequest.AddDTO request) { | |||
public ReviewResponse.FindAllByPlannerDTO findReviewsByPlanner(int page, Long plannerId) { | |||
Pageable pageable = PageRequest.of(page, PAGE_SIZE); | |||
Page<Review> pageContent = reviewJPARepository.findAllByMatchPlannerId(plannerId, pageable); | |||
System.out.println("1번!"); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
println 다 지워주세요!
@@ -10,15 +10,12 @@ | |||
public interface ReviewImageItemJPARepository extends JpaRepository<ReviewImageItem, Long> { | |||
|
|||
@Modifying | |||
@Query("delete from ReviewImageItem r where r.review.id = :reviewId") | |||
@Query("delete from ReviewImageItem i where i.review.id = :reviewId") |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
이 부분 다른 코드랑 일관성이 안 맞는 것 같아요 r로 변경 부탁드립니다!
SET REFERENTIAL_INTEGRITY FALSE; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ctrl+Shift+Tab 해서 탭 없애주세요
한 일