Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

리뷰 이미지 조회 쿼리 오타 수정 #186

Merged
merged 2 commits into from
Nov 10, 2023
Merged

리뷰 이미지 조회 쿼리 오타 수정 #186

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
d9afc2e
fix: modifying reviewImageItem JPA query
Nov 10, 2023
34fc9b1
Merge branch 'weekly' of https://github.com/Step3-kakao-tech-campus/T…
Nov 10, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions sunsu-wedding/src/main/java/com/kakao/sunsuwedding/review/ReviewServiceImpl.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -72,15 +72,15 @@ public ReviewResponse.FindAllByPlannerDTO findReviewsByPlanner(int page, Long pl
Pageable pageable = PageRequest.of(page, PAGE_SIZE);
Page<Review> pageContent = reviewJPARepository.findAllByMatchPlannerId(plannerId, pageable);
List<Review> reviews = pageContent.getContent();
List<ReviewImageItem> reviewImageItems = reviewImageItemJPARepository.findByReviewMatchPlannerId(plannerId);
List<ReviewImageItem> reviewImageItems = reviewImageItemJPARepository.findAllByReviewMatchPlannerId(plannerId);

return reviewDTOConverter.getFindAllByPlannerDTO(reviews, reviewImageItems);
}

public ReviewResponse.FindAllByCoupleDTO findReviewsByCouple(User user) {

List<Review> reviews = reviewJPARepository.findAllByMatchCoupleId(user.getId());
List<ReviewImageItem> reviewImageItems = reviewImageItemJPARepository.findByReviewMatchCoupleId(user.getId());
List<ReviewImageItem> reviewImageItems = reviewImageItemJPARepository.findAllByReviewMatchCoupleId(user.getId());

return reviewDTOConverter.getFindAllByCoupleDTO(reviews, reviewImageItems);
}
Expand Down
7 changes: 5 additions & 2 deletions ...dding/src/main/java/com/kakao/sunsuwedding/review/image/ReviewImageItemJPARepository.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,8 +13,11 @@ public interface ReviewImageItemJPARepository extends JpaRepository<ReviewImageI
@Query("delete from ReviewImageItem r where r.review.id = :reviewId")
void deleteAllByReviewId(@Param("reviewId") Long reviewId);

List<ReviewImageItem> findByReviewMatchPlannerId(@Param("plannerId") Long plannerId);
List<ReviewImageItem> findByReviewMatchCoupleId(@Param("coupleId") Long coupleId);
@Query("select r from ReviewImageItem r where r.review.match.planner.id = :plannerId")
List<ReviewImageItem> findAllByReviewMatchPlannerId(@Param("plannerId") Long plannerId);

@Query("select r from ReviewImageItem r where r.review.match.couple.id = :coupleId")
List<ReviewImageItem> findAllByReviewMatchCoupleId(@Param("coupleId") Long coupleId);

@Query("select r.image from ReviewImageItem r where r.review.id = :reviewId")
List<String> findByReviewId(@Param("reviewId") Long reviewId);
Expand Down
Loading