[FEAT] #3 투표 생성 #16
Merged
[FEAT] #3 투표 생성 #16
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kssumin
approved these changes
Sep 29, 2023
This was referenced Oct 1, 2023
Merged
jinwooseok
reviewed
Oct 5, 2023
|
|
||
| // 2. 옵션 개수가 2개 ~ 6개 인지 확인 후 예외처리 | ||
| int size = requestDto.getOptions().size(); | ||
| if (size < 2 || size > 6) { |
There was a problem hiding this comment.
2, 6 이런거 min, max 이런식으로 정의해두고 하면 좋지 않을까요?
jinwooseok
reviewed
Oct 5, 2023
| // 2. 옵션 개수가 2개 ~ 6개 인지 확인 후 예외처리 | ||
| int size = requestDto.getOptions().size(); | ||
| if (size < 2 || size > 6) { | ||
| throw new OptionNumException("선택지의 개수는 2개 이하 6개 이상이어야 합니다."); |
There was a problem hiding this comment.
이런 부분도 나중에 바뀌게 되면 놓칠수도 있으니까 위에거랑 한번에 바꾸면 좋지않을까요?
jinwooseok
reviewed
Oct 5, 2023
| System.out.println(requestDto); | ||
| VoteEntity vote = voteJPARepository.save(requestDto.toEntity()); | ||
| long voteId = vote.getId(); | ||
| for (CreateVoteRequest.OptionDTO option : requestDto.getOptions()) { |
There was a problem hiding this comment.
DTO랑 Dto랑 하나만 선택하면 좋을거같아요
jinwooseok
reviewed
Oct 5, 2023
| } | ||
|
|
||
| @Getter | ||
| @Setter |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
어떤 내용에 대한 PR인가요?
투표 생성에 관한 pr입니다.
투표 옵션 이미지 처리는 미구현입니다.
변경 사항
변경된 부분에 대한 상세한 내용을 나열해주세요
무엇을 위주로 보면 좋을까요?
관련된 이슈
투표 생성 (#3)
테스트 방법
컨트롤러 테스트