Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FEATURE: parallel preview/push is now default #3132

Merged
merged 2 commits into from
Sep 26, 2024
Merged

Conversation

tlimoncelli
Copy link
Contributor

OLD:

  • push/preview -- Gathers zone info serially
  • ppush/ppreview -- Gathers zone info in parallel

NEW:

  • oldpush/oldpreview -- Gathers zone info serially
  • push/preview / ppush/ppreview -- Gathers zone info in parallel

The serial and parallel versions should be equivalent. If you need to use the old* commands, please file a bug explaining why ASAP.
The legacy oldpush/oldpreview commands will go away eventually. Maybe a month?

@tlimoncelli tlimoncelli merged commit 0f08087 into main Sep 26, 2024
16 checks passed
@tlimoncelli tlimoncelli deleted the tlim_oldnewpreview branch September 26, 2024 17:09
@cafferata
Copy link
Collaborator

@tlimoncelli I didn't expect a merge yet, how do we deal with the documentation? This tells something different than this GitHub pull request does.

The ppreview/ppush subcommands are a preview of a future feature where zone data is gathered concurrently. The commands will go away when they replace the existing preview/push commands.

@tlimoncelli
Copy link
Contributor Author

Doh! I'll do that in a separate PR. Mea culpa!

@cafferata
Copy link
Collaborator

Cross-linking: #3133

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants