-
Notifications
You must be signed in to change notification settings - Fork 18
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
CWALL-254: Added vc validation against the schema #243
base: develop
Are you sure you want to change the base?
Conversation
…g the vc against the schema plus some bugfixes. also made checking vc against the schema optional
The logic should be the other way around. Just like how we handle expiration and credential status. When the object is present, it means the issuer values the respective feature of the VCDM. So when they issue with a schema, we should always validate, unless an option was set to not validate. So something like noSchemaValidation makes more sense. Or even nicer an enum named SchemaValidation, with values, ALWAYS, NEVER, WHEN_PRESENT. That allows you to configure from a wallet or RP perspective whether you always need schema's, whether you will not verify schema's or only when the issuer added schema's |
…on module for verifying credentials.
…on module for verifying credentials.
…basedon_from-funke # Conflicts: # packages/oid4vci-holder/src/agent/OID4VCIHolderService.ts # packages/siopv2-oid4vp-op-auth/src/session/functions.ts # pnpm-lock.yaml
IMPORTANT NOTE
the examples that I see from ebsi, all have some discrepancies. so I've added an option to dictate whether we want to check the vc against it's schema or not: