Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

BED-4766: Correctly Format SAML Provider Details in ListAuthProviders Endpoint #915

Merged
merged 2 commits into from
Oct 25, 2024
Merged

BED-4766: Correctly Format SAML Provider Details in ListAuthProviders Endpoint #915

merged 2 commits into from
Oct 25, 2024
+6 −5

Conversation

iustinum
Copy link
Contributor

@iustinum iustinum commented Oct 25, 2024 •
edited
Loading

Description

This update applies FormatSAMLProviderURL to the SAML provider details in the ListAuthProviders API endpoint for consistent and correct formatting of provider information. See original PR here.

Motivation and Context

This PR addresses: BED-4766

How Has This Been Tested?

  • Manually validated through API endpoint requests
  • Confirmed with existing unit and integration tests

Screenshots (optional):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)

Checklist:

@iustinum iustinum self-assigned this Oct 25, 2024
@iustinum iustinum added bug Something isn't working api A pull request containing changes affecting the API code. labels Oct 25, 2024
mistahj67
mistahj67 approved these changes Oct 25, 2024
View reviewed changes
Copy link
Contributor

@mistahj67 mistahj67 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the quick turnaround! 🙇

@iustinum iustinum enabled auto-merge (squash) October 25, 2024 21:34
@iustinum iustinum merged commit f8813f8 into main Oct 25, 2024
4 checks passed
@iustinum iustinum deleted the BED-4766-formatSAMLProvider branch October 25, 2024 21:38
@github-actions github-actions bot locked and limited conversation to collaborators Oct 25, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@mistahj67 mistahj67 mistahj67 approved these changes

Assignees

@iustinum iustinum

Labels
api A pull request containing changes affecting the API code. bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@iustinum @mistahj67