Bed 4805 #905
Open
Bed 4805 #905
+512
−13
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stephanieslamb
added
documentation
juggernot325
requested changes
Oct 18, 2024
packages/go/openapi/src/paths/attack-paths.domains.id.details.yaml
Outdated
Show resolved
Hide resolved
| // | ||
| // SPDX-License-Identifier: Apache-2.0 | ||
|
|
||
| package api |
There was a problem hiding this comment.
I really like this refactor! Can we open up a ticket to update all existing endpoints to use these functions?
There was a problem hiding this comment.
yeah, i can do that. i think when alyx and i originally talked about this, we thought it would be more like something i demo in demo/retro and then people will know the option is there. but if a ticket seems better, i can get that created!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
As part of a refactor, moved a few filtering functions and an interface to the api package where it can be used elsewhere. Also updated OpenAPI spec with new fields for attack path details handler.
Motivation and Context
This PR addresses: BED-4805
Why is this change required? What problem does it solve?
This was part of a refactor to clean up duplicated code.
How Has This Been Tested?
Unit tests still pass.
Screenshots (optional):
Types of changes
Checklist: