-
Notifications
You must be signed in to change notification settings - Fork 109
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bed 4805 #905
base: main
Are you sure you want to change the base?
Bed 4805 #905
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Found a couple minor things.
packages/go/openapi/src/paths/attack-paths.domains.id.details.yaml
Outdated
Show resolved
Hide resolved
// | ||
// SPDX-License-Identifier: Apache-2.0 | ||
|
||
package api |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I really like this refactor! Can we open up a ticket to update all existing endpoints to use these functions?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yeah, i can do that. i think when alyx and i originally talked about this, we thought it would be more like something i demo in demo/retro and then people will know the option is there. but if a ticket seems better, i can get that created!
Description
As part of a refactor, moved a few filtering functions and an interface to the api package where it can be used elsewhere. Also updated OpenAPI spec with new fields for attack path details handler.
Motivation and Context
This PR addresses: BED-4805
Why is this change required? What problem does it solve?
This was part of a refactor to clean up duplicated code.
How Has This Been Tested?
Unit tests still pass.
Screenshots (optional):
Types of changes
Checklist: