Bed-4852: SSO Provider Delete Endpoint #890
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mvlipka
added
the
work in progress
mistahj67
reviewed
Sep 26, 2024
3 tasks
…ble to allow for easy cascade on delete. Added audit logging to deleting sso_providers
mvlipka
changed the title
mvlipka
changed the title
mvlipka
added
api
mistahj67
reviewed
Oct 16, 2024
mistahj67
requested changes
Oct 16, 2024
mistahj67
reviewed
Oct 17, 2024
…place of DeleteSSOProvider
mistahj67
reviewed
Oct 17, 2024
…of letting the PG contraint to remove references
mistahj67
reviewed
Oct 23, 2024
|
|
||
| -- Set the user's saml_provider_id to null when an sso_provider or saml_provider is deleted | ||
| ALTER TABLE ONLY users | ||
| DROP CONSTRAINT fk_users_saml_provider; |
There was a problem hiding this comment.
Suggested change
| DROP CONSTRAINT fk_users_saml_provider; | |
| DROP CONSTRAINT IF EXISTS fk_users_saml_provider; |
mistahj67
approved these changes
Oct 24, 2024
cmd/api/src/api/v2/auth/sso.go
Outdated
Comment on lines
152
to
154
| } else if err = s.db.DeleteSSOProvider(request.Context(), ssoProviderID); errors.Is(err, database.ErrNotFound) { | ||
| api.WriteErrorResponse(request.Context(), api.BuildErrorResponse(http.StatusNotFound, err.Error(), request), response) | ||
| } else if err != nil { |
There was a problem hiding this comment.
Suggested change
| } else if err = s.db.DeleteSSOProvider(request.Context(), ssoProviderID); errors.Is(err, database.ErrNotFound) { | |
| api.WriteErrorResponse(request.Context(), api.BuildErrorResponse(http.StatusNotFound, err.Error(), request), response) | |
| } else if err != nil { | |
| } else if err = s.db.DeleteSSOProvider(request.Context(), ssoProviderID); err != nil { |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Add a new endpoint to delete SSO Providers
Motivation and Context
This PR addresses: BED-4852
Adds the ability for admins to delete SSO Providers and any associated references to them
How Has This Been Tested?
Basic Test
I setup my database as followed:
Sent a request to
/api/v2/sso-providers/{sso_provider_id}And received a 200 response back
Refreshing the tables in the database shows that the references were properly nulled out
Attempting to delete a non-existent sso provider:
Attempting to delete a SAML provider after replacing DeleteSAMLProvider with the DeleteSSOProvider method
After sending the request:
And the audit log with details:
Screenshots (optional):
Types of changes
Checklist: