Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bed 4694: require auth for feature flags request #788

Merged
merged 7 commits into from
Aug 16, 2024

Conversation

benwaples
Copy link
Contributor

Description

Doesnt make GET /features request until the user has logged in, accepted EULA (if applicable), and doesnt have an expired password

Motivation and Context

This PR addresses: BED-4694

We are making requests before the user is fully authed, meaning those requests will return either 401 (no token) or 403 (token but missing EULA or expired password). Creating noise from the browser client.

How Has This Been Tested?

Added unit test for the Inner component logic inside the App wrapper
Tested all Auth flows: Login, login and reset password, MFA login, login and accept EULA (if applicable), forbidden user, SSO

Screenshots (optional):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)

Checklist:

@benwaples benwaples added bug Something isn't working user interface A pull request containing changes affecting the UI code. labels Aug 13, 2024
@benwaples benwaples self-assigned this Aug 13, 2024
@benwaples benwaples changed the title Bed 4694 : require auth for feature flags request Bed 4694: require auth for feature flags request Aug 14, 2024
Copy link
Collaborator

@elikmiller elikmiller left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

@benwaples benwaples merged commit 240ae87 into main Aug 16, 2024
4 checks passed
@benwaples benwaples deleted the BED-4694--require-auth-for-feature-flags branch August 16, 2024 19:50
@github-actions github-actions bot locked and limited conversation to collaborators Aug 16, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Something isn't working user interface A pull request containing changes affecting the UI code.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants