-
Notifications
You must be signed in to change notification settings - Fork 109
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
BED-4537: Create Share endpoint #775
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good!
@irshadaj I'd still like another pair of eyes on it since I'm a bit bias here 😄
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I had a number of questions as well that we DM'd and it looks like there's some additional work on the table still.
packages/go/openapi/src/schemas/model.saved-queries-permissions-request.yaml
Outdated
Show resolved
Hide resolved
packages/go/openapi/src/schemas/model.saved-queries-permissions.yaml
Outdated
Show resolved
Hide resolved
packages/go/openapi/src/schemas/model.saved-queries-permissions.yaml
Outdated
Show resolved
Hide resolved
cd67c46
to
69e5213
Compare
BED-4537 db methods by Mike BED-4537 added database functionality to query for all scopes, integration tests for that BED-4537 linter fix for error BED-4537 added ability to delete saved query permissions and integration tests for it BED-4537 added ability to delete saved query permissions, bulk create saved query permissions, and integration tests BED-4537 forgot to push batch changes, whoops! BED-4537 fix linting error Addressed PR feedback, corrected yaml files and unit tests Address PR feedback and optimization changes Refactored control flow logic, added TONS of unit tests, added some integration tests, and altered some database functions Refactored logic, added unit/integration tests, handled merge conflicts Addressed previous PR feedback and adjusted unit tests Corrected openapi stuff Changed the endpoint url More openapi corrections and file name change Addressed PR feedback and fixed unit/integration tests
a038e15
to
4643ced
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks solid! I had a few small changes to shore up testing / cleaning but don't want to block merging 🚀 once you've tackled those. Great job and thanks for your patience while we iterated through the scenarios and logic, it came out clean! 🧼
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🚀
Description
ShareSavedQueries
endpointMotivation and Context
Why is this change required? What problem does it solve?
How Has This Been Tested?
OpenAPI preview (but please check on how this looks like for you!)
Types of changes
Checklist: