-
Notifications
You must be signed in to change notification settings - Fork 109
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
BED-4366 -- parse negative numbers in Cypher queries #661
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…--parse-negatives-cypher
maffkipp
changed the title
BED-4366 -- Parse negative numbers in Cypher queries
BED-4366 -- parse negative numbers in Cypher queries
Jun 21, 2024
maffkipp
added
api
A pull request containing changes affecting the API code.
bug
Something isn't working
labels
Jun 21, 2024
…--parse-negatives-cypher
superlinkx
approved these changes
Jul 17, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks clean, pull!
zinic
approved these changes
Jul 18, 2024
I'm looking in the code for something that says |
…--parse-negatives-cypher
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Our arithmetic expression parsing for cypher queries was silently dropping the operator from negative numbers. This change adds a model for unary expressions that will carry the operator through and allow us to handle it as a separate case in the backend.
Motivation and Context
Some of our saved queries use negative numbers for matching by property values, and we are currently returning unexpected results to the user when they use those queries.
How Has This Been Tested?
Additional positive test cases have been added to confirm we now allow negative numbers, and that this does not otherwise impact the way we parse arithmetic expressions.
Screenshots (if appropriate):
Types of changes
Checklist: