Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

BED-4391: FedRAMP EULA backend #645

Merged
merged 12 commits into from
Jun 25, 2024
Merged

BED-4391: FedRAMP EULA backend #645

merged 12 commits into from
Jun 25, 2024

Conversation

computator
Copy link
Contributor

@computator computator commented Jun 5, 2024 •
edited
Loading

Description

  • Added a UserSessionFlag mechanism to store boolean flags associated with a UserSession
  • Added a JSONBBoolObject to assist in storing map[string]bool values in jsonb columns

Motivation and Context

Enterprise only feature. This is the supporting functionality on the BHCE side.

How Has This Been Tested?

Manually tested with the BHE side by calling the appropriate API endpoints. Added tests.

Screenshots (if appropriate):

Types of changes

  • Chore (a change that does not modify the application functionality)
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • Documentation updates are needed, and have been made accordingly.
  • I have added and/or updated tests to cover my changes.
  • All new and existing tests passed.
  • My changes include a database migration.

mistahj67
mistahj67 reviewed Jun 5, 2024
View reviewed changes
Copy link
Contributor

@mistahj67 mistahj67 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I realize it's a draft still so just did a preliminary comment sesh and all are just suggestions, we can discuss more offline!

cmd/api/src/database/migration/migrations/v5.x.x.sql Outdated Show resolved Hide resolved
cmd/api/src/model/audit.go Outdated Show resolved Hide resolved
cmd/api/src/database/migration/migrations/v5.x.x.sql Outdated Show resolved Hide resolved
@mistahj67 mistahj67 marked this pull request as ready for review June 24, 2024 19:29
@sircodemane sircodemane added enhancement New feature or request api A pull request containing changes affecting the API code. labels Jun 25, 2024
mistahj67
mistahj67 approved these changes Jun 25, 2024
View reviewed changes
Copy link
Contributor

@mistahj67 mistahj67 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why have 2 checkmarks, when you can have 3! ✅

@computator computator merged commit f875b42 into main Jun 25, 2024
3 checks passed
@computator computator deleted the fedramp-eula-backend branch June 25, 2024 20:22
@github-actions github-actions bot locked and limited conversation to collaborators Jun 25, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@ddlees ddlees ddlees approved these changes

@brandonshearin brandonshearin brandonshearin approved these changes

@mistahj67 mistahj67 mistahj67 approved these changes

Assignees
No one assigned
Labels
api A pull request containing changes affecting the API code. enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@computator @ddlees @brandonshearin @mistahj67 @sircodemane