BED-4299 -- Display members of custom asset groups on Group Management #623
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
GET api/v2/asset-groups/{asset_group_id}/members
currently only queries thesystem_tags
property to determine AG membership. This means any custom asset groups created through the API will not return any results via this endpoint, since membership in those groups is stored on theuser_tags
property instead.This fix updates the query to check for the asset group tag in both the
system_tags
anduser_tags
field. I also added a check after the query to filter out nodes that do not have an exact match in the tag list, due to the potential for naming collisions with ourStringContains
query (for example, a custom asset group with tagtest_tag_1
also pulling in nodes with tagtest_tag
).Motivation and Context
If a user is creating custom asset groups via the API, we want them to be able to view and modify those asset groups via the Group Management page (or the
api/v2/asset-groups/{asset_group_id}/members
endpoint).How Has This Been Tested?
Screenshots (if appropriate):
Types of changes
Checklist: