Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Corrected YAML updates - Indentation and ops order #617

Merged
merged 6 commits into from
May 24, 2024

Conversation

slokie-so
Copy link
Collaborator

@slokie-so slokie-so commented May 17, 2024

Description

Introduces Community PR Ticketing, allowing the workflow to confirm the organization prior to creating a ticket. Updates to Jira Issue Ticketing, resulting in a confirmation workflow after creation to ensure there is enough information collected prior to ticketing to Jira. Updates the incorrect link to the corrected HTML link

Motivation and Context

Reduce incomplete information for Bug / Feature Requests, introduce Community PR tickets to allow Engineering to review and merge community PR with normalized workflow

How Has This Been Tested?

YAML verified through validator plugin
Will need to test live, since self-hosted runner is the only permitted worker for this workflow

Screenshots (if appropriate):

Types of changes

  • Chore (a change that does not modify the application functionality)
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • Documentation updates are needed, and have been made accordingly.
  • I have added and/or updated tests to cover my changes.
  • All new and existing tests passed.
  • My changes include a database migration.

GITHUB_TOKEN="${{ secrets.GITHUB_TOKEN }}"
PR_ORG=$(jq -r .pull_request.head.repo.organization.login "$GITHUB_EVENT_PATH")
PR_USER=$(jq -r .pull_request.user.login "$GITHUB_EVENT_PATH")
if [ -z "$TEAM_MEMBERSHIP" ]; then
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This appears to be missing the code block to actually run below it. Also due to the missing code block I can't tell where you are using the variables added in the above lines, but I don't believe those variables will be passed on to the next steps if that's the intention. To share them they would need to be put into the actions env file or an output.

@slokie-so slokie-so merged commit 54275bc into main May 24, 2024
3 checks passed
@slokie-so slokie-so deleted the q1-workflow-update-v2 branch May 24, 2024 20:41
@github-actions github-actions bot locked and limited conversation to collaborators May 24, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants