Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: featureflag for auto tagging T0 AD group members #616

Closed
wants to merge 6 commits into from

Conversation

JonasBK
Copy link
Collaborator

@JonasBK JonasBK commented May 17, 2024

Description

Add a feature flag to enable/disable auto-tagging of Tier Zero AD group members

Ticket: BP-702

Motivation and Context

Some users (mostly BHE users) prefer no automatic Tier Zero tagging of Tier Zero AD group members as they would like to manually verify new members of Tier Zero groups. The feature flag allows them to disable the auto-tagging.

For BHE users, disabling the member auto-tagging will result in MemberOf findings, which comes with the BHE pull request 536. That PR should be merged at the same time as this PR.

How Has This Been Tested?

Tested locally. Disabled and enabled it a couple of times to confirm it works.

We should perform a performance test with BHE to confirm that analysis does not increase significantly with this change.

Screenshots (if appropriate):

Types of changes

  • Chore (a change that does not modify the application functionality)
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • Documentation updates are needed, and have been made accordingly.
  • I have added and/or updated tests to cover my changes.
  • All new and existing tests passed.
  • My changes include a database migration.

@JonasBK JonasBK added the enhancement New feature or request label Jun 5, 2024
@urangel urangel changed the base branch from main to stage/v5.11.0 June 10, 2024 14:33
Base automatically changed from stage/v5.11.0 to main June 21, 2024 18:08
@JonasBK JonasBK marked this pull request as ready for review August 13, 2024 09:39
cmd/api/src/daemons/datapipe/agi.go Outdated Show resolved Hide resolved
@JonasBK JonasBK added the work in progress This pull request is a work in progress and should not be merged label Sep 2, 2024
@JonasBK
Copy link
Collaborator Author

JonasBK commented Sep 2, 2024

Issue identified. Will investigate.

@irshadaj irshadaj added the external This pull request is from an external contributor label Sep 11, 2024
@JonasBK JonasBK closed this Oct 4, 2024
@github-actions github-actions bot locked and limited conversation to collaborators Oct 4, 2024
@JonasBK
Copy link
Collaborator Author

JonasBK commented Oct 4, 2024

Closing this PR as we will implement the feature later in another way.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
enhancement New feature or request external This pull request is from an external contributor work in progress This pull request is a work in progress and should not be merged
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants