chore: more cleanup

cmd/api/src/database/db.go

@@ -242,7 +242,7 @@ func (s *BloodhoundDB) Wipe(ctx context.Context) error {
 
 func (s *BloodhoundDB) Migrate(ctx context.Context) error {
 	// Run the migrator
-	if err := migration.NewMigrator(s.db.WithContext(ctx)).Migrate(); err != nil {
+	if err := migration.NewMigrator(s.db.WithContext(ctx)).ExecuteStepwiseMigrations(); err != nil {
 		log.Errorf("Error during SQL database migration phase: %v", err)
 		return err
 	}

cmd/api/src/database/migration/migration.go

@@ -18,7 +18,6 @@ package migration
 
 import (
 	"embed"
-	"fmt"
 	"io/fs"
 
 	"github.com/specterops/bloodhound/src/version"
@@ -56,11 +55,3 @@ func NewMigrator(db *gorm.DB) *Migrator {
 		DB: db,
 	}
 }
-
-func (s *Migrator) Migrate() error {
-	if err := s.executeStepwiseMigrations(); err != nil {
-		return fmt.Errorf("failed to execute stepwise migrations: %w", err)
-	}
-
-	return nil
-}

cmd/api/src/database/migration/migration_integration_test.go

@@ -286,7 +286,7 @@ func TestMigrator_Migrate(t *testing.T) {
 	manifest, err := migrator.GenerateManifest()
 	require.Nil(t, err)
 
-	assert.Nil(t, migrator.Migrate())
+	assert.Nil(t, migrator.ExecuteStepwiseMigrations())
 
 	lastVersionInManifest := manifest.VersionTable[len(manifest.VersionTable)-1]
 	latestMigration, err := migrator.LatestMigration()

cmd/api/src/database/migration/stepwise.go

@@ -145,7 +145,7 @@ func (s *Migrator) RequiresMigration() (bool, error) {
 	}
 }
 
-// executeStepwiseMigrations will run all necessary migrations for a deployment.
+// ExecuteStepwiseMigrations will run all necessary migrations for a deployment.
 // It begins by checking if migration schema exists. If it does not, we assume the
 // deployment is a new installation, otherwise we assume it may have migration updates.
 //
@@ -156,7 +156,7 @@ func (s *Migrator) RequiresMigration() (bool, error) {
 // and then build a manifest starting after the last successful version
 //
 // Once schema is verified and a manifest is created, we run ExecuteMigrations.
-func (s *Migrator) executeStepwiseMigrations() error {
+func (s *Migrator) ExecuteStepwiseMigrations() error {
 	var (
 		manifest      Manifest
 		lastMigration model.Migration