Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

UI: Extract Trace Logger custom format tooltip strings into resources file for localization #61

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

icefairy64
Copy link

When looking through the source code I have noticed a few hardcoded English strings and decided to take a shot at extracting them into the resource file to allow for proper localization.

Initially I wanted to introduce a new complex resource tag along the lines of Tooltip / Multiline for this, but I have no idea what the best approach to separate tooltip structure and localizable strings would be in that case, so I decided against it for now.

Not quite sure if the proposed approach is appropriate - happy to hear any feedback on this!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant