-
-
Notifications
You must be signed in to change notification settings - Fork 601
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: 添加项目成员 #353
Open
liulijun4959
wants to merge
5
commits into
SonicCloudOrg:main
Choose a base branch
from
liulijun4959:dev
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
feat: 添加项目成员 #353
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
添加后你打算怎么鉴权呢?实际上之前我们有打算建设过 #317 |
项目表加了一个创建人字段,可以用来鉴权,只有项目创建者才能做添加或删除成员,并且删除项目。。项目成员不能做这些操作 |
作用并不是那么大,因为里面的控件、用例等信息还是没有走鉴权 |
对的,可以考虑慢慢优化。近期部署sonic平台后,项目组同事就反馈了一些问题:登录之后可以看到所有的项目,而且没法查看项目组成员,最大的问题是都可以在项目设置页面进行删除,风险较大。所以我只是做了简单的修改,至少可以解决当下项目成员的问题 |
这个先放着,设计上没有我们想得那么完美,我们还在看有没有更佳的方式,先感谢您这边的贡献, |
ZhouYixun
added
good first issue
Good for newcomers
and removed
good first issue
Good for newcomers
labels
May 16, 2023
4 tasks
# Conflicts: # sonic-server-controller/src/main/java/org/cloud/sonic/controller/models/domain/Projects.java # sonic-server-controller/src/main/java/org/cloud/sonic/controller/models/dto/ProjectsDTO.java
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
Description