Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SOL-115142: Added HowToImplementTracingManualInstrumentation #38

Merged
merged 8 commits into from
Oct 9, 2024

Conversation

aelsammak
Copy link
Contributor

@aelsammak aelsammak commented Jun 12, 2024

This snippet demonstrates HowTo do the following:

  • howToInjectTraceContextInSolaceMessage
  • howToExtractTraceContextIfAnyFromSolaceMessage
  • howToCreateSpanAndBaggageOnMessagePublish
  • howToCreateNewSpanOnMessageReceive

NOTE: The build.gradle and pom.xml will need to be updated with dependencies for PS+ Java OTEL integration module (new dependency), Open-telemetry (new dependency) and also update the PS+ Java dependency once the context propagation feature is released. (solace-messaging-client to 1.7.0)

I am including the pom.xml & build.gradle changes in the PR as a reminder to myself for what needs to updated after the release.

^ Both have now been correctly updated

@aelsammak
Copy link
Contributor Author

FOR THE REVIEWER

(probably @Mrc0113 or @aaron-613 ??)

I based this snippet off the JCSMP one for manual instrumentation .

However, the JCSMP samples project has a separate folder called features which includes another folder separately for the DT feature containing classes such as TracingUtil, etc.

Can be found here.

This samples project does not have a features folder so I did not include those classes. My PR only contains the "HowToImplementTracingManualInstrumentation". Please let me know if we decide that there is a need for the other classes and where to put them.

@Mrc0113 Mrc0113 requested a review from aaron-613 July 2, 2024 15:16
@aelsammak aelsammak marked this pull request as ready for review September 18, 2024 19:58
@aelsammak
Copy link
Contributor Author

aelsammak commented Sep 18, 2024

@Mrc0113 @aaron-613 PS+ Java 1.7.0 & Java OTEL 1.0.0 are both released now. So I am changing this PR from a draft to ready-for-review!

@aaron-613
Copy link
Contributor

Hey @aelsammak , I'm gonna be taking a look at this now! Just wondering, did you check out the updates to JCSMP samples that Jamil made a while ago? He modified/tweaked a lot of the samples that R&D produced. https://github.com/SolaceSamples/solace-samples-java-jcsmp/tree/master/src/main/java/com/solace/samples/jcsmp/features/distributedtracing

@aelsammak
Copy link
Contributor Author

Hey @aelsammak , I'm gonna be taking a look at this now! Just wondering, did you check out the updates to JCSMP samples that Jamil made a while ago? He modified/tweaked a lot of the samples that R&D produced. https://github.com/SolaceSamples/solace-samples-java-jcsmp/tree/master/src/main/java/com/solace/samples/jcsmp/features/distributedtracing

Hello @aaron-613, I did check out the updates by Jamil and I see several classes were added to the "features" folder. I left a comment about this here: #38 (comment)

@aaron-613
Copy link
Contributor

Updated the code, mostly Gradle and Maven JAR dependencies, fixed some warnings.
Added a comment to one method.
Code review in progress, noted a couple issue above.

@aelsammak
Copy link
Contributor Author

@aaron-613 Good catches! I addressed your comments :)

Copy link
Contributor

@aaron-613 aaron-613 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yup, code looks fine now.

@aaron-613 aaron-613 merged commit f9fce23 into SolaceSamples:main Oct 9, 2024
1 check failed
@aaron-613
Copy link
Contributor

Squashed and merged, even with that GItHub Action warning for tutorials something something.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants