SOL-59692: Provide Ability to NACK a Specific AD Message and Force Re-delivery #66

oodigie · 2024-10-09T18:15:54Z

Changes:

EBP-52: Implement the receiver builder configuration for message settlement outcome support
EBP-54: Implement the Settle() method
EBP-54: fixed doc string format on MessageSettlementOutcome
EBP-58: added new metrics and response code for Nack
EBP-58: tracked auto-acks and subtract it from settledAccepted

…lement outcome support

TrentDaniel · 2024-10-10T19:00:35Z

internal/impl/core/metrics.go

+}
+
+func (backedMetrics *ccsmpBackedMetrics) incrementDuplicateAckCount() {
+	atomic.AddUint64(&backedMetrics.duplicateAcks, uint64(1))


@oodigie , why do we need a new function and attribute for counting duplicate acks instead of incrementing the stat using the existing method?

gitstream-cm · 2024-10-21T21:08:05Z

Please mark whether you used Copilot to assist coding in this PR

oodigie added 5 commits October 2, 2024 11:42

EBP-52: Implement the receiver builder configuration for message sett…

90c3175

…lement outcome support

EBP-54: Implement the Settle() method

37f8578

EBP-54: fixed doc string format on MessageSettlementOutcome

648b60f

EBP-58: added new metrics and response code for Nack

fe4303c

EBP-58: tracked auto-acks and substract it from settledAccepted

578d614

oodigie requested review from cjwmorgan-sol, RagnarPaulson, TrentDaniel and sdewilde October 9, 2024 18:15

TrentDaniel reviewed Oct 10, 2024

View reviewed changes

oodigie and others added 3 commits October 10, 2024 16:12

EBP-60: write unit and integration tests

4eb83a4

Adding some dummy tests to see through a small change.

94fdbfa

A few more simple tests.

b9b192b

oodigie marked this pull request as ready for review October 21, 2024 21:06

Provide feedback