Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(comomn): move StructureDoc to common #3514

Merged
merged 1 commit into from
Oct 15, 2024
Merged

Conversation

pYassine
Copy link
Contributor

No description provided.

Copy link

sonarcloud bot commented Oct 15, 2024

@codecov-commenter
Copy link

codecov-commenter commented Oct 15, 2024

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

Attention: Patch coverage is 82.00000% with 9 lines in your changes missing coverage. Please review.

Project coverage is 67.24%. Comparing base (c3257a1) to head (a735a39).
Report is 2 commits behind head on master.

Files with missing lines Patch % Lines
...ackend/src/interactions/interactions.controller.ts 25.00% 3 Missing ⚠️
...dules/structures/services/structure-doc.service.ts 33.33% 2 Missing ⚠️
...structures/controllers/structure-doc.controller.ts 66.66% 1 Missing ⚠️
.../services/custom-docs/generateCustomDoc.service.ts 0.00% 1 Missing ⚠️
...ge-download-docs/manage-download-docs.component.ts 0.00% 1 Missing ⚠️
...cs-table/structures-custom-docs-table.component.ts 75.00% 1 Missing ⚠️

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #3514      +/-   ##
==========================================
+ Coverage   67.20%   67.24%   +0.04%     
==========================================
  Files         898      896       -2     
  Lines       14782    14770      -12     
  Branches     2097     2102       +5     
==========================================
- Hits         9934     9932       -2     
+ Misses       4693     4553     -140     
- Partials      155      285     +130     
Files with missing lines Coverage Δ
...tructure-doc/constants/CUSTOM_DOCS_LABELS.const.ts 100.00% <ø> (ø)
...src/_common/model/structure-doc/constants/index.ts 100.00% <ø> (ø)
...s/backend/src/_common/model/structure-doc/index.ts 100.00% <100.00%> (ø)
...end/src/_common/model/structure-doc/types/index.ts 100.00% <100.00%> (ø)
...ckend/src/auth/services/structures-auth.service.ts 86.11% <100.00%> (ø)
...ges/backend/src/auth/structures-auth.controller.ts 80.64% <100.00%> (ø)
...ntities/structure-doc/StructureDocTable.typeorm.ts 100.00% <ø> (ø)
...es/structure-doc/structureDocRepository.service.ts 100.00% <100.00%> (ø)
...tail-admin-login/portail-admin-login.controller.ts 100.00% <100.00%> (ø)
...ules/portail-admin/services/admins-auth.service.ts 91.30% <100.00%> (ø)
... and 45 more

... and 56 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c3257a1...a735a39. Read the comment docs.

@pYassine pYassine merged commit 266fd1f into master Oct 15, 2024
11 of 12 checks passed
@pYassine pYassine deleted the feat-delete-admin-stats branch October 15, 2024 23:22
@SocialGroovyBot
Copy link
Member

🎉 This PR is included in version 2.178.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants