Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat delete admin stats #3513

Merged
merged 3 commits into from
Oct 15, 2024
Merged

Feat delete admin stats #3513

merged 3 commits into from
Oct 15, 2024

Conversation

pYassine
Copy link
Contributor

No description provided.

Copy link

socket-security bot commented Oct 14, 2024

👍 Dependency issues cleared. Learn more about Socket for GitHub ↗︎

This PR previously contained dependency changes with security issues that have been resolved, removed, or ignored.

View full report↗︎

Copy link

sonarcloud bot commented Oct 15, 2024

Quality Gate Failed Quality Gate failed

Failed conditions
B Reliability Rating on New Code (required ≥ A)

See analysis details on SonarCloud

Catch issues before they fail your Quality Gate with our IDE extension SonarLint

Copy link

New and removed dependencies detected. Learn more about Socket for GitHub ↗︎

Package New capabilities Transitives Size Publisher
npm/@eslint-community/[email protected] None 0 431 kB eslint-community-bot
npm/@eslint/[email protected] filesystem, unsafe +1 732 kB eslintbot
npm/@eslint/[email protected] None 0 13.9 kB eslintbot
npm/@faker-js/[email protected] None 0 10.2 MB shinigami92
npm/@humanwhocodes/[email protected] Transitive: environment +2 133 kB nzakas
npm/@types/[email protected] None 0 7.65 kB types
npm/@types/[email protected] None 0 2.09 MB types
npm/@typescript-eslint/[email protected] None 0 2.69 MB jameshenry
npm/@typescript-eslint/[email protected] None 0 18 kB jameshenry
npm/@typescript-eslint/[email protected] None 0 613 kB jameshenry
npm/@typescript-eslint/[email protected] None 0 109 kB jameshenry
npm/@typescript-eslint/[email protected] None 0 156 kB jameshenry
npm/@typescript-eslint/[email protected] Transitive: environment +2 1.02 MB jameshenry
npm/@typescript-eslint/[email protected] None 0 332 kB jameshenry
npm/@typescript-eslint/[email protected] None 0 19.4 kB jameshenry
npm/[email protected] None 0 24.4 kB rreverser
npm/[email protected] None 0 531 kB marijn
npm/[email protected] None 0 221 kB dcode
npm/[email protected] None 0 35 kB sindresorhus
npm/[email protected] None 0 106 kB eslint
npm/[email protected] None 0 146 kB eslintbot
npm/[email protected] environment, filesystem 0 3.04 MB eslintbot
npm/[email protected] None +1 1.04 MB michaelficarra
npm/[email protected] None 0 13.5 kB michaelficarra
npm/[email protected] filesystem +1 109 kB mrmlnc
npm/[email protected] None 0 41.9 kB matteo.collina
npm/[email protected] filesystem 0 25.6 kB royriojas
npm/[email protected] None 0 11.8 kB sindresorhus
npm/[email protected] filesystem 0 29.4 kB jaredwray
npm/[email protected] filesystem 0 55.1 kB isaacs
npm/[email protected] filesystem 0 21.8 kB sindresorhus
npm/[email protected] None 0 27.8 kB jaredwray
npm/[email protected] None 0 24.9 kB gkz
npm/[email protected] filesystem 0 7.02 kB sindresorhus
npm/[email protected] None 0 56.6 kB doowb
npm/[email protected] None +1 71.3 kB gkz
npm/[email protected] None 0 7.75 kB sindresorhus
npm/[email protected] None 0 7.24 kB sindresorhus
npm/[email protected] environment, filesystem, unsafe 0 8.39 MB prettier-bot
npm/[email protected] filesystem 0 17.3 kB isaacs
npm/[email protected] None 0 95.4 kB npm-cli-ops
npm/[email protected] None 0 7.04 kB sindresorhus
npm/[email protected] None 0 828 kB joshuakgoldberg
npm/[email protected] None 0 81.1 kB jameshenry
npm/[email protected] None 0 470 kB garycourt

🚮 Removed packages: npm/@isaacs/[email protected], npm/@isaacs/[email protected], npm/@jest/[email protected], npm/@npmcli/[email protected], npm/@npmcli/[email protected], npm/@npmcli/[email protected], npm/@npmcli/[email protected], npm/@npmcli/[email protected], npm/@pkgjs/[email protected], npm/@sigstore/[email protected], npm/@sigstore/[email protected], npm/@sigstore/[email protected], npm/@sigstore/[email protected], npm/@sigstore/[email protected], npm/@sigstore/[email protected], npm/@sinclair/[email protected], npm/@tufjs/[email protected], npm/@tufjs/[email protected], npm/@types/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected]

View full report↗︎

@codecov-commenter
Copy link

codecov-commenter commented Oct 15, 2024

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

Attention: Patch coverage is 95.58824% with 6 lines in your changes missing coverage. Please review.

Project coverage is 67.20%. Comparing base (42206fd) to head (0971ca0).
Report is 4 commits behind head on master.

Files with missing lines Patch % Lines
.../backend/src/stats/services/publicStats.service.ts 94.33% 2 Missing and 1 partial ⚠️
packages/backend/src/auth/jwt/jwt.strategy.ts 75.00% 1 Missing ⚠️
...port-stats-deploiement/statsDeploiementExporter.ts 50.00% 1 Missing ⚠️
...rs/admin-structures/admin-structures.controller.ts 94.73% 1 Missing ⚠️

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #3513      +/-   ##
==========================================
- Coverage   67.69%   67.20%   -0.50%     
==========================================
  Files         910      898      -12     
  Lines       14995    14782     -213     
  Branches     2091     2093       +2     
==========================================
- Hits        10151     9934     -217     
+ Misses       4804     4693     -111     
- Partials       40      155     +115     
Files with missing lines Coverage Δ
packages/backend/src/_common/model/index.ts 100.00% <ø> (ø)
...I_SECURITY_STRUCTURE_CONTROLLER_TEST_DEFS.const.ts 100.00% <100.00%> (ø)
...end/src/_tests/SECURITY_TESTS_NEST_MODULE.const.ts 100.00% <100.00%> (ø)
packages/backend/src/app.module.ts 100.00% <100.00%> (ø)
packages/backend/src/auth/auth.module.ts 100.00% <100.00%> (ø)
...ackend/src/excel/export-stats-deploiement/index.ts 100.00% <100.00%> (ø)
...renderer/exportListeStructuresWorksheetRenderer.ts 100.00% <100.00%> (ø)
...heet-renderer/exportListeUsersWorksheetRenderer.ts 100.00% <100.00%> (ø)
...port-stats-deploiement/worksheet-renderer/index.ts 100.00% <ø> (ø)
...rc/modules/portail-admin/_dto/MetabaseStats.dto.ts 90.00% <ø> (ø)
... and 23 more

... and 61 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 42206fd...0971ca0. Read the comment docs.

@pYassine pYassine merged commit d404519 into master Oct 15, 2024
10 of 12 checks passed
@pYassine pYassine deleted the feat-delete-admin-stats branch October 15, 2024 20:14
@SocialGroovyBot
Copy link
Member

🎉 This PR is included in version 2.177.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants