Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(open-data): add structureType #3510

Merged
merged 2 commits into from
Oct 9, 2024
Merged

Conversation

pYassine
Copy link
Contributor

@pYassine pYassine commented Oct 9, 2024

No description provided.

Copy link

New and removed dependencies detected. Learn more about Socket for GitHub ↗︎

Package New capabilities Transitives Size Publisher
npm/@eslint-community/[email protected] None 0 431 kB eslint-community-bot
npm/@eslint/[email protected] filesystem, unsafe 0 659 kB eslintbot
npm/@eslint/[email protected] None 0 13.9 kB eslintbot
npm/@faker-js/[email protected] None 0 10.2 MB shinigami92
npm/@humanwhocodes/[email protected] None 0 55.6 kB nzakas
npm/@nodelib/[email protected] filesystem 0 22.2 kB mrmlnc
npm/@nodelib/[email protected] filesystem 0 11.8 kB mrmlnc
npm/@nodelib/[email protected] None 0 26.4 kB mrmlnc
npm/@types/[email protected] None 0 7.65 kB types
npm/@types/[email protected] None 0 2.09 MB types
npm/@types/[email protected] None 0 4.89 kB types
npm/@typescript-eslint/[email protected] None 0 2.69 MB jameshenry
npm/@typescript-eslint/[email protected] None 0 18 kB jameshenry
npm/@typescript-eslint/[email protected] None 0 613 kB jameshenry
npm/@typescript-eslint/[email protected] None 0 109 kB jameshenry
npm/@typescript-eslint/[email protected] None 0 156 kB jameshenry
npm/@typescript-eslint/[email protected] None 0 576 kB jameshenry
npm/@typescript-eslint/[email protected] None 0 332 kB jameshenry
npm/@typescript-eslint/[email protected] None 0 19.4 kB jameshenry
npm/[email protected] None 0 24.4 kB rreverser
npm/[email protected] None 0 531 kB marijn
npm/[email protected] None 0 17 kB sindresorhus
npm/[email protected] environment, filesystem 0 172 kB vitaly
npm/[email protected] None 0 3.17 kB sindresorhus
npm/[email protected] None 0 6.94 kB juliangruber
npm/[email protected] None 0 221 kB dcode
npm/[email protected] None 0 44.6 kB jonschlinkert
npm/[email protected] None 0 6.33 kB sindresorhus
npm/[email protected] None 0 35 kB sindresorhus
npm/[email protected] None 0 27.2 kB qix
npm/[email protected] None 0 4.86 kB substack
npm/[email protected] environment, filesystem, shell 0 21.2 kB satazor
npm/[email protected] environment 0 42.4 kB qix
npm/[email protected] None 0 5.42 kB sindresorhus
npm/[email protected] None 0 106 kB eslint
npm/[email protected] None 0 146 kB eslintbot
npm/[email protected] environment, filesystem 0 3.04 MB eslintbot
npm/[email protected] None 0 73.6 kB eslintbot
npm/[email protected] None 0 1 MB michaelficarra
npm/[email protected] None 0 13.5 kB michaelficarra
npm/[email protected] None 0 13 kB esp
npm/[email protected] filesystem 0 96.7 kB mrmlnc
npm/[email protected] None 0 41.9 kB matteo.collina
npm/[email protected] filesystem 0 25.6 kB royriojas
npm/[email protected] None 0 16.7 kB jonschlinkert
npm/[email protected] None 0 11.8 kB sindresorhus
npm/[email protected] filesystem 0 29.4 kB jaredwray
npm/[email protected] environment, filesystem 0 13.4 kB isaacs
npm/[email protected] filesystem 0 21.8 kB sindresorhus
npm/[email protected] None 0 51.5 kB kael
npm/[email protected] None 0 4.87 kB sindresorhus
npm/[email protected] None 0 11.9 kB jensyt
npm/[email protected] None 0 3.96 kB isaacs
npm/[email protected] None 0 6.22 kB jonschlinkert
npm/[email protected] None 0 13.6 kB phated
npm/[email protected] None 0 9.62 kB jonschlinkert
npm/[email protected] environment, filesystem 0 11 kB isaacs
npm/[email protected] None 0 27.8 kB jaredwray
npm/[email protected] None 0 24.9 kB gkz
npm/[email protected] filesystem 0 7.02 kB sindresorhus
npm/[email protected] None 0 54.1 kB jdalton
npm/[email protected] None 0 8.9 kB zensh
npm/[email protected] None 0 56.6 kB doowb
npm/[email protected] None 0 6.84 kB styfle
npm/[email protected] None 0 4.05 kB isaacs
npm/[email protected] None 0 50.2 kB gkz
npm/[email protected] None 0 7.75 kB sindresorhus
npm/[email protected] None 0 7.24 kB sindresorhus
npm/[email protected] None 0 3.92 kB sindresorhus
npm/[email protected] None 0 4.55 kB sindresorhus
npm/[email protected] filesystem 0 5.41 kB sindresorhus
npm/[email protected] environment, filesystem, unsafe 0 8.39 MB prettier-bot
npm/[email protected] None 0 8.37 kB feross
npm/[email protected] filesystem, unsafe 0 4.64 kB sindresorhus
npm/[email protected] None 0 9.44 kB matteo.collina
npm/[email protected] filesystem 0 17.3 kB isaacs
npm/[email protected] None 0 6.56 kB feross
npm/[email protected] None 0 95.4 kB npm-cli-ops
npm/[email protected] None 0 2.56 kB kevva
npm/[email protected] None 0 2.83 kB sindresorhus
npm/[email protected] None 0 36.3 kB trott
npm/[email protected] None 0 22.9 kB jonschlinkert
npm/[email protected] None 0 828 kB joshuakgoldberg
npm/[email protected] None 0 21.2 kB gkz
npm/[email protected] None 0 81.1 kB jameshenry
npm/[email protected] None 0 73.1 kB ethan_arrowood
npm/[email protected] None 0 470 kB garycourt
npm/[email protected] environment 0 9.97 kB isaacs
npm/[email protected] None 0 2.96 kB zkat

View full report↗︎

@codecov-commenter
Copy link

codecov-commenter commented Oct 9, 2024

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

Attention: Patch coverage is 46.80851% with 50 lines in your changes missing coverage. Please review.

Project coverage is 67.69%. Comparing base (bd83a53) to head (70335e0).
Report is 3 commits behind head on master.

Files with missing lines Patch % Lines
packages/backend/src/open-data-places/load-mss.ts 0.00% 10 Missing and 1 partial ⚠️
.../src/_migrations/1728487458329-manual-migration.ts 41.17% 9 Missing and 1 partial ⚠️
...ackend/src/open-data-places/load-data-inclusion.ts 0.00% 8 Missing and 1 partial ⚠️
...ges/backend/src/open-data-places/load-soliguide.ts 0.00% 8 Missing and 1 partial ⚠️
.../src/_migrations/1728487663488-manual-migration.ts 36.36% 6 Missing and 1 partial ⚠️
...uctures/controllers/admin-structures.controller.ts 50.00% 2 Missing ⚠️
...p/modules/structures/utils/structure-validators.ts 33.33% 2 Missing ⚠️

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #3510      +/-   ##
==========================================
+ Coverage   67.63%   67.69%   +0.05%     
==========================================
  Files         906      910       +4     
  Lines       14953    14995      +42     
  Branches     2084     2104      +20     
==========================================
+ Hits        10114    10151      +37     
- Misses       4670     4674       +4     
- Partials      169      170       +1     
Files with missing lines Coverage Δ
...src/open-data-places/functions/getStructureType.ts 100.00% <100.00%> (ø)
...es/backend/src/open-data-places/functions/index.ts 100.00% <100.00%> (ø)
...ta-places/functions/tests/STRUCTURE_NAMES.const.ts 100.00% <100.00%> (ø)
.../src/stats/controllers/stats.private.controller.ts 84.31% <100.00%> (ø)
...d/src/stats/controllers/stats.public.controller.ts 100.00% <100.00%> (ø)
...cture-edit-form/structure-edit-form.component.html 100.00% <ø> (ø)
...uctures/controllers/admin-structures.controller.ts 62.88% <50.00%> (ø)
...p/modules/structures/utils/structure-validators.ts 52.94% <33.33%> (+6.99%) ⬆️
.../src/_migrations/1728487663488-manual-migration.ts 36.36% <36.36%> (ø)
...ackend/src/open-data-places/load-data-inclusion.ts 0.00% <0.00%> (ø)
... and 3 more

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update bd83a53...70335e0. Read the comment docs.

@pYassine pYassine merged commit 9303465 into master Oct 9, 2024
8 of 9 checks passed
@pYassine pYassine deleted the feat-detect-structure-type branch October 9, 2024 17:51
Copy link

sonarcloud bot commented Oct 9, 2024

@SocialGroovyBot
Copy link
Member

🎉 This PR is included in version 2.176.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants