feat(anonymisation): anonymiser les utiliseurs quand on le supprime en mettant leur initiales #1480
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
carolineBda
temporarily deployed
to
review-auto
GitHub Actions
Inactive
carolineBda
temporarily deployed
to
review-auto
GitHub Actions
Inactive
m-maillot
approved these changes
Sep 26, 2024
| }) | ||
| .toPromise(); | ||
|
|
||
| if ( | ||
| deleteResult.data?.update_auth_users_by_pk.name !== userId || | ||
| deleteResult.data?.update_auth_users_by_pk.id !== userId || |
There was a problem hiding this comment.
Du coup on avait un bug ici ?
There was a problem hiding this comment.
non avant comme le nom était l'id on checkait le nom et ça marchait mais maintenant il faut bien checker sur l'id
|
|
||
| UPDATE auth.users | ||
| SET name = 'CL' | ||
| WHERE id = 'aa6d1721-71e5-42a8-bf26-98f453d1fab5'; |
There was a problem hiding this comment.
Ca a du être sympa de retrouver les personnes 😄
There was a problem hiding this comment.
j'ai regardé dans le fichier audit ^^
There was a problem hiding this comment.
pratique cette table audit :)
Co-authored-by: Martial Maillot <[email protected]>
carolineBda
temporarily deployed
to
review-auto
GitHub Actions
Inactive
m-maillot
reviewed
Sep 26, 2024
| export const deleteUser = async (userId: string): Promise<boolean> => { | ||
| const anonymizeUser = (userName: string, userId: string): string => { | ||
| if (!userName?.length) return userId.slice(4); | ||
| return userName.toUpperCase().split(" ").map((word) => word[0]).join(); |
There was a problem hiding this comment.
Suggested change
| return userName.toUpperCase().split(" ").map((word) => word[0]).join(); | |
| return userName.toUpperCase().split(" ").map((word) => word[0]).join(""); |
désolé 🙈
carolineBda
temporarily deployed
to
review-auto
GitHub Actions
Inactive
|
|
🎉 Deployment for commit 9145b27 : Docker images
|
Viczei
approved these changes
Sep 30, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.