Skip to content

Commit

Permalink
fix(accessibility): label puce (#1452)
Browse files Browse the repository at this point in the history
* fix(accesibility): label puce

* fix(accessibility): puce politique de conf
  • Loading branch information
alebret authored Oct 11, 2022
1 parent 8bcddf3 commit ef6202e
Show file tree
Hide file tree
Showing 3 changed files with 31 additions and 13 deletions.
17 changes: 8 additions & 9 deletions front/src/components/article/links.component.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -34,19 +34,18 @@ const Links: FC<Props> = ({ linksArray }) => {
<SubTitle title={Labels.article.learnMoreAboutIt} />
<View style={styles.linksContainer}>
{_.filter(linksArray, "label").map((item, index) => (
<ListItem.Content key={index} style={[styles.linkContainer]}>
<SecondaryText
style={styles.dot}
importantForAccessibility="no"
accessibilityElementsHidden
accessible={false}
>
<ListItem.Content
key={index}
style={[styles.linkContainer]}
accessibilityRole="tab"
>
<SecondaryText style={styles.dot} accessibilityLabel="Puces">
{SpecialChars.blackLargeCircle}
</SecondaryText>
<SecondaryText
accessibilityRole="link"
style={styles.link}
onPress={goToUrl(item.url)}
accessibilityRole="link"
>
{item.label}
</SecondaryText>
Expand All @@ -60,7 +59,7 @@ const Links: FC<Props> = ({ linksArray }) => {
const styles = StyleSheet.create({
dot: {
color: Colors.primaryBlue,
fontSize: Sizes.xxxxxs,
fontSize: Sizes.xxxxs,
lineHeight: Sizes.lg,
textAlignVertical: "top",
},
Expand Down
25 changes: 22 additions & 3 deletions front/src/components/html/li.component.tsx
Original file line number Diff line number Diff line change
@@ -1,19 +1,38 @@
import * as React from "react";
import { StyleSheet } from "react-native";

import { Paddings } from "../../styles";
import SpecialChars from "../../constants/specialChars";
import { Colors, Margins, Paddings, Sizes } from "../../styles";
import type { TextProps } from "../baseComponents";
import { SecondaryText } from "../baseComponents";
import { SecondaryText, View } from "../baseComponents";

const Li: React.FC<TextProps> = (props) => {
const newProps = {
...props,
children: `${props.children}`,
};
return <SecondaryText {...newProps} style={[styles.li, props.style]} />;
return (
<View style={styles.content}>
<SecondaryText style={styles.dot} accessibilityLabel="Puces">
{SpecialChars.blackLargeCircle}
</SecondaryText>
<SecondaryText {...newProps} style={[styles.li, props.style]} />
</View>
);
};

const styles = StyleSheet.create({
content: {
display: "flex",
flexDirection: "row",
},
dot: {
color: Colors.primaryBlue,
fontSize: Sizes.xxxxs,
lineHeight: Sizes.lg,
marginRight: Margins.default,
textAlignVertical: "top",
},
li: {
paddingVertical: Paddings.smallest,
},
Expand Down
2 changes: 1 addition & 1 deletion front/src/utils/aroundMe/aroundMe.util.ts
Original file line number Diff line number Diff line change
Expand Up @@ -26,7 +26,7 @@ export const getPostalCodeCoords = async (

return newCoords;
} catch (error: unknown) {
console.log(error);
console.warn(error);
return undefined;
}
};
Expand Down

0 comments on commit ef6202e

Please sign in to comment.