Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Audit-4: Comments on Shell #1318

Merged
merged 2 commits into from
Oct 25, 2024
Merged

Audit-4: Comments on Shell #1318

merged 2 commits into from
Oct 25, 2024

Conversation

yrong
Copy link
Contributor

@yrong yrong commented Oct 21, 2024

@yrong yrong mentioned this pull request Oct 21, 2024
Closed
@yrong yrong changed the title Comments on Shell Audit-4: Comments on Shell Oct 21, 2024
alistair-singh
alistair-singh approved these changes Oct 21, 2024
View reviewed changes
Copy link
Contributor

@alistair-singh alistair-singh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1

vgeddes
vgeddes reviewed Oct 24, 2024
View reviewed changes
contracts/src/Shell.sol Outdated Show resolved Hide resolved
@yrong @vgeddes
Update contracts/src/Shell.sol
09194a4 
Co-authored-by: Vincent Geddes <[email protected]>
@yrong yrong merged commit 5fc0337 into main Oct 25, 2024
3 checks passed
@yrong yrong deleted the ron/comments-on-shell branch October 25, 2024 03:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vgeddes vgeddes vgeddes left review comments

@alistair-singh alistair-singh alistair-singh approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@yrong @vgeddes @alistair-singh