Adds Paseo to control tool #1295
Conversation
# Conflicts: # control/Cargo.lock # control/Cargo.toml # control/preimage/Cargo.toml # control/preimage/src/asset_hub_runtime.rs # control/preimage/src/bridge_hub_runtime.rs # control/preimage/src/constants.rs # control/preimage/src/helpers.rs # control/preimage/src/relay_runtime.rs
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1295 +/- ##
==========================================
- Coverage 77.83% 72.54% -5.29%
==========================================
Files 14 18 +4
Lines 415 601 +186
Branches 76 108 +32
==========================================
+ Hits 323 436 +113
- Misses 75 156 +81
+ Partials 17 9 -8
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
control/runtimes/paseo/src/lib.rs
Outdated
| @@ -0,0 +1,3 @@ | |||
| pub mod runtime; | |||
There was a problem hiding this comment.
Why are you subxt codegen for the paseo runtime, instead of the derive macro used in the other runtimes?
For example Westend:
#[subxt::subxt(
runtime_metadata_path = "polkadot-metadata.bin",
derive_for_all_types = "Clone"
)]
mod runtime {}
pub use runtime::*;
I dislike subxt codegen as it creates huge files that slow down our repo. whereas the macro does the codegen on the fly locally.
There was a problem hiding this comment.
Agreed, 02a7335.
There was a problem hiding this comment.
This README is becoming a bit stale. Can you delete lines 43-73, and update lines 78-onwards to reflect current reality.
There was a problem hiding this comment.
Updated. 02a7335.
control/README.md
Outdated
| @@ -79,3 +79,8 @@ subxt metadata --url ws://127.0.0.1:8000 -f bytes -o runtimes/polkadot/polkadot- | |||
| subxt metadata --url ws://127.0.0.1:8001 -f bytes -o runtimes/bridge-hub-polkadot/bridge-hub-metadata.bin | |||
| subxt metadata --url ws://127.0.0.1:8002 -f bytes -o runtimes/asset-hub-polkadot/asset-hub-metadata.bin | |||
| ``` | |||
|
|
|||
| Update runtime.rs: | |||
There was a problem hiding this comment.
Why is Paseo a special case in the readme?
There was a problem hiding this comment.
I removed it, it's not necessary anymore.
Adds Paseo in the control tool to generate commands.