Adding support for Private key file based authentication #149
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vyanamandra
requested review from
sfc-gh-nsehrawat,
sfc-gh-rehuang,
sfc-gh-dasilva,
sfc-gh-cnivera and
sfc-gh-yayin
as code owners
| @@ -169,6 +169,28 @@ set SNOWFLAKE_AUTHENTICATOR=externalbrowser | |||
| os.environ['SNOWFLAKE_AUTHENTICATOR'] = 'externalbrowser' | |||
| ``` | |||
|
|
|||
| 4. Private Key based authentication | |||
| ```bash | |||
| SNOWFLAKE_AUTHENTICATOR= | |||
There was a problem hiding this comment.
It might be confusing to some folks about setting this to the empty string, I'd just leave a comment that this doesn't need to be set:
Suggested change
| SNOWFLAKE_AUTHENTICATOR= | |
| # no SNOWFLAKE_AUTHENTICATOR needed |
| if not SNOWFLAKE_PASSWORD and not SNOWFLAKE_AUTHENTICATOR: | ||
| missing_env_vars.append("SNOWFLAKE_PASSWORD/SNOWFLAKE_AUTHENTICATOR") | ||
| if not SNOWFLAKE_AUTHENTICATOR: | ||
| if not SNOWFLAKE_PASSWORD and not SNOWFLAKE_PRIVATE_KEY_FILE: |
There was a problem hiding this comment.
I'm assuming SNOWFLAKE_PASSWORD and SNOWFLAKE_PRIVATE_KEY_FILE are mutually exclusive (i.e. you can have one or the other but not both)? If that's the case, it might be nice to make the message a little clearer to the user:
Suggested change
| if not SNOWFLAKE_PASSWORD and not SNOWFLAKE_PRIVATE_KEY_FILE: | |
| if not SNOWFLAKE_PASSWORD: | |
| missing_env_vars.append("SNOWFLAKE_PASSWORD/SNOWFLAKE_AUTHENTICATOR") | |
| elif not SNOWFLAKE_PRIVATE_KEY_FILE: | |
| missing_env_vars.append("SNOWFLAKE_PRIVATE_KEY_FILE") |
| @@ -417,9 +417,18 @@ def _get_user(self) -> str: | |||
| ) | |||
| return user | |||
|
|
|||
| def _is_authentication_setup(self) -> bool: | |||
| password = env_vars.SNOWFLAKE_PASSWORD | |||
| private_key_file = env_vars.SNOWFLAKE_PRIVATE_KEY_FILE | |||
There was a problem hiding this comment.
Do we need to be also verifying the presence of SNOWFLAKE_PRIVATE_KEY_FILE_PWD?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please review my changes for adding private key file based authentication.
I have tested the changes locally.