Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Prepare Firmware Constants for Gestures Release #997

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Prepare Firmware Constants for Gestures Release #997

wants to merge 1 commit into from

Conversation

9il
Copy link
Contributor

@9il 9il commented Apr 21, 2024

No description provided.

@9il 9il mentioned this pull request Apr 21, 2024
Merged
ImUrX
ImUrX reviewed Jun 18, 2024
View reviewed changes
Copy link
Member

@ImUrX ImUrX left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we currently can't merge this kind of stuff before we are able to see a sample of the product or the code itself if its open-source.

@9il
Copy link
Contributor Author

9il commented Jun 18, 2024

It is not open source as well as the sony mocopi

@ImUrX
Copy link
Member

ImUrX commented Jun 18, 2024

sony mocopi was added when moslime was made, which was an open-source contribution

@9il
Copy link
Contributor Author

9il commented Jun 24, 2024

What open source contribution Sony made that is more valuable then ours?

We want to make a product with SlimeVR support from the start.

@ButterscotchV ButterscotchV added Priority: Normal The default priority Type: Enhancement Adds or improves a feature Area: Server Related to the server Status: Blocked by other issue Progress cannot be made until linked issue is resolved labels Jul 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ImUrX ImUrX ImUrX left review comments

@ButterscotchV ButterscotchV Awaiting requested review from ButterscotchV ButterscotchV is a code owner

@Eirenliel Eirenliel Awaiting requested review from Eirenliel Eirenliel is a code owner

@Erimelowo Erimelowo Awaiting requested review from Erimelowo Erimelowo is a code owner

At least 2 approving reviews are required to merge this pull request.

Assignees
No one assigned
Labels
Area: Server Related to the server Priority: Normal The default priority Status: Blocked by other issue Progress cannot be made until linked issue is resolved Type: Enhancement Adds or improves a feature
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@9il @ImUrX @ButterscotchV