Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Expand skeleton height config #1156

Draft
wants to merge 22 commits into
base: main
Choose a base branch
from
Draft

Expand skeleton height config #1156

wants to merge 22 commits into from

Conversation

ButterscotchV
Copy link
Member

@ButterscotchV ButterscotchV commented Sep 8, 2024 •
edited by ImUrX
Loading

Replaces the basic height configuration that is part of AutoBone with one that includes the floor height. This value is also used when resetting proportions, so you no longer need to be in a specific pose for that.

Requires SlimeVR/SolarXR-Protocol#147.

Remaining tasks:

  • Handle not having positional trackers
  • Load current height/floor values from config
    • Loaded values are valid if height - floor >= 0.4
  • Value validation
    • Values are valid if height - floor >= 0.4
    • Must warn user they cannot continue because the resulting height is invalid
  • Warn user if no height is configured when resetting proportions

ButterscotchV and others added 20 commits April 4, 2024 04:19
@ButterscotchV
Base proportion limits off defaults directly
d769fa3
@ButterscotchV
Change height config
b803eb3 
- Make height off max and min tracker positions
- Move HMD height to skeleton
- Remove full height as it's never used
@ButterscotchV
Reset proportions based on hmd height config
5317db0
@ButterscotchV
Fix AutoBone HMD height
67e2941
@ButterscotchV
Add floor height config
125f27e
@ButterscotchV
Merge remote-tracking branch 'upstream/main' into height-config
cf8f6c6
@ImUrX
Merge branch 'main' into height-config
48d330a
@ButterscotchV
Merge remote-tracking branch 'upstream/main' into height-config
f5bf2e2
@ButterscotchV
Update solarxr-protocol
abc534e
@ImUrX
continue later, need to think
aded461
@ImUrX
finish the steps
07f2f63
@ImUrX
Merge branch 'main' into height-config
587cb97
@ImUrX
solarxr
1b91d7f
@ImUrX
Merge branch 'main' into height-config
bd2cfd1
@ImUrX
continuing with height pages
95de93d
@ImUrX
add scaled proportions step
49fd367
@ButterscotchV
Don't select internal trackers for height
a1a428e
@ButterscotchV
Fix floor height & crashing with no trackers
85c0199
@ButterscotchV
Change defaults & fix minimum height
71d383d
@ButterscotchV
Remove steps & remove timer on reset proportions
fa2d634
@ButterscotchV ButterscotchV added Priority: Normal The default priority Area: GUI Related to the GUI Type: Enhancement Adds or improves a feature Area: Translation Improvements or additions to translations Area: Server Related to the server labels Sep 8, 2024
@ButterscotchV ButterscotchV added the Status: Blocked by other issue Progress cannot be made until linked issue is resolved label Sep 8, 2024
@ButterscotchV ButterscotchV changed the title Add skeleton height config Expand skeleton height config Sep 8, 2024
@ButterscotchV ButterscotchV mentioned this pull request Sep 8, 2024
Draft
This was referenced Sep 17, 2024
Open
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Eirenliel Eirenliel Awaiting requested review from Eirenliel Eirenliel will be requested when the pull request is marked ready for review Eirenliel is a code owner

@Erimelowo Erimelowo Awaiting requested review from Erimelowo Erimelowo will be requested when the pull request is marked ready for review Erimelowo is a code owner

@ImUrX ImUrX Awaiting requested review from ImUrX ImUrX will be requested when the pull request is marked ready for review ImUrX is a code owner

@loucass003 loucass003 Awaiting requested review from loucass003 loucass003 will be requested when the pull request is marked ready for review loucass003 is a code owner

At least 2 approving reviews are required to merge this pull request.

Assignees

@ImUrX ImUrX

@ButterscotchV ButterscotchV

Labels
Area: GUI Related to the GUI Area: Server Related to the server Area: Translation Improvements or additions to translations Priority: Normal The default priority Status: Blocked by other issue Progress cannot be made until linked issue is resolved Type: Enhancement Adds or improves a feature
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ButterscotchV @ImUrX