Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DBus reversal of path and interface naming scheme #525

Merged
merged 10 commits into from
Apr 24, 2024

Conversation

jbbjarnason
Copy link
Contributor

@jbbjarnason jbbjarnason commented Mar 21, 2024

Todo

pending, @SindriTh will fix the Configurator and Filters view in Connections

What's been done

  • Now DBus interface have same name if they offer the same interface, path determines uniqueness of interface instance
    • Applies to: Config, IPC, Motor, and probably more
  • Split Config&Schema from (ss) to Config s prop and Schema s
  • Make interface of confman only accepting shared dbus connection
  • Value DBus Signal made in IPC to propagate updates @omarhogni

@jbbjarnason jbbjarnason linked an issue Mar 21, 2024 that may be closed by this pull request
@jbbjarnason jbbjarnason changed the title 517 improve performance of iodebug DBus reversal of path and interface naming scheme Mar 21, 2024
@SindriTh
Copy link
Member

I have gotten the Configurator and Filter Modal working. Feel free to try it out/break it

@jbbjarnason
Copy link
Contributor Author

jbbjarnason commented Apr 5, 2024

I have gotten the Configurator and Filter Modal working. Feel free to try it out/break it

@SindriTh the confman_example_item does not appear in the schema list. though it appears in the process list
image

@SindriTh
Copy link
Member

SindriTh commented Apr 5, 2024

I have gotten the Configurator and Filter Modal working. Feel free to try it out/break it

@SindriTh the confman_example_item does not appear in the schema list. though it appears in the process list

Interesting, I will look into this.

@jbbjarnason jbbjarnason force-pushed the 517-improve-performance-of-iodebug branch 2 times, most recently from 501b0ef to 946fba9 Compare April 16, 2024 09:38
@jbbjarnason jbbjarnason force-pushed the 517-improve-performance-of-iodebug branch from 648879a to e7cf35c Compare April 24, 2024 13:38
jbbjarnason and others added 3 commits April 24, 2024 13:39
Signal tinker interface modified for easier listening @omarhogni
sml dbus interface <-> path
remove io context interface to confman requiring refactor in many many places
change dbus naming of api for motors, path <-> interface
make distinct interface for slot and signal
now trying to restructure dbus api
@jbbjarnason jbbjarnason marked this pull request as ready for review April 24, 2024 13:42
@jbbjarnason jbbjarnason force-pushed the 517-improve-performance-of-iodebug branch from ff6a887 to bbf886a Compare April 24, 2024 14:08
@jbbjarnason jbbjarnason force-pushed the 517-improve-performance-of-iodebug branch from b03fa39 to 2d80a99 Compare April 24, 2024 14:11
Copy link

sonarcloud bot commented Apr 24, 2024

Quality Gate Passed Quality Gate passed

Issues
4 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

cockpit/src/Components/Form/WidgetFunctions.tsx Outdated Show resolved Hide resolved
cockpit/src/Components/Form/WidgetFunctions.tsx Outdated Show resolved Hide resolved
cockpit/src/Components/Form/WidgetFunctions.tsx Outdated Show resolved Hide resolved
cockpit/src/Components/Form/WidgetFunctions.tsx Outdated Show resolved Hide resolved
exes/ethercat/inc/public/tfc/ec.hpp Outdated Show resolved Hide resolved
@omarhogni omarhogni merged commit 825a8af into main Apr 24, 2024
15 checks passed
@omarhogni omarhogni deleted the 517-improve-performance-of-iodebug branch April 24, 2024 14:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Improve performance of IODebug
3 participants