Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Dbus connection contained in manager client or external #188
Dbus connection contained in manager client or external #188
Changes from 20 commits
4253f58
ff891ed
5e5f5e1
6f36774
ddb751d
ee29e42
8944130
e106cb3
8cee350
8a07d6b
5967676
3956003
7a562bd
80f6aab
4c4cde4
9939946
ca05f49
f86e4d1
2103908
d0a2863
18f47cd
ef5e4ac
bb30e1c
b92f098
3fc29f1
3e444f0
71dce6c
bf5cc59
7a67cac
d69ef4f
689ef6b
e2cef61
f0f76eb
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
This file was deleted.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
changed path of config, should we change the
property_name
as well to capital first letter? @SindriThThere was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sounds good to me, what does the DBUS naming standard say?
Check failure on line 27 in libs/confman/src/detail/config_dbus_client.cpp
GitHub Actions / ubuntu packaging (debug, x86_64)
Check failure on line 27 in libs/confman/src/detail/config_dbus_client.cpp
GitHub Actions / ubuntu packaging (debug, aarch64)
Check failure on line 27 in libs/confman/src/detail/config_dbus_client.cpp
GitHub Actions / build and run tests (gcc-debug)
Check failure on line 27 in libs/confman/src/detail/config_dbus_client.cpp
GitHub Actions / ubuntu packaging (release, x86_64)
Check failure on line 27 in libs/confman/src/detail/config_dbus_client.cpp
GitHub Actions / build and run tests (gcc-release)
Check failure on line 27 in libs/confman/src/detail/config_dbus_client.cpp
GitHub Actions / ubuntu packaging (release, aarch64)
Check failure on line 27 in libs/confman/src/detail/config_dbus_client.cpp
GitHub Actions / build and run tests (gcc-debug-dynamic)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
So you create a interface to share with multiple parties.
then one of the parties initalizes the interface?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yes, similar to dbus connection