Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Mqtt broadcaster that reads signals off of ipc and forwards them to MQTT broker #115

Closed
wants to merge 6 commits into from
Closed

Mqtt broadcaster that reads signals off of ipc and forwards them to MQTT broker #115

wants to merge 6 commits into from

Conversation

magni-mar
Copy link
Contributor

No description provided.

@magni-mar magni-mar force-pushed the mqtt_broadcaster branch 6 times, most recently from 6e4e21c to 5436f0f Compare July 4, 2023 17:07
jbbjarnason
jbbjarnason reviewed Jul 5, 2023
View reviewed changes
docs/design/mqtt_broadcaster.md Outdated Show resolved Hide resolved
exes/mqtt-broadcaster/CMakeLists.txt Show resolved Hide resolved
exes/mqtt-broadcaster/CMakeLists.txt Outdated Show resolved Hide resolved
exes/mqtt-broadcaster/inc/mqtt_broadcaster.hpp Outdated Show resolved Hide resolved
exes/mqtt-broadcaster/inc/mqtt_broadcaster.hpp Outdated Show resolved Hide resolved
exes/mqtt-broadcaster/src/main.cpp Outdated Show resolved Hide resolved
exes/mqtt-broadcaster/tests/mqtt_broadcaster_tests.cpp Outdated Show resolved Hide resolved
exes/mqtt-broadcaster/tests/mqtt_broadcaster_tests.cpp
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would suggest making unit tests for each part of the code, but this probably covers the use cases but it is hard to read through the tests.

exes/mqtt-broadcaster/tests/mqtt_broadcaster_tests.cpp Outdated Show resolved Hide resolved
exes/mqtt-broadcaster/tests/mqtt_broadcaster_tests.cpp Outdated Show resolved Hide resolved
@magni-mar magni-mar force-pushed the mqtt_broadcaster branch 2 times, most recently from c713ed8 to 4afdf30 Compare July 5, 2023 16:29
@magni-mar magni-mar closed this Jul 14, 2023
@magni-mar
Copy link
Contributor Author

Closing this PR because more features need to be added to the executable until it can be merged, such as SparkPlug B and more.

@magni-mar magni-mar reopened this Jul 14, 2023
@magni-mar magni-mar marked this pull request as draft July 14, 2023 08:58
@omarhogni omarhogni closed this Aug 8, 2023
@omarhogni omarhogni deleted the mqtt_broadcaster branch January 24, 2024 11:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jbbjarnason jbbjarnason jbbjarnason left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@magni-mar @jbbjarnason @omarhogni