-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Mqtt broadcaster that reads signals off of ipc and forwards them to MQTT broker #115
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
magni-mar
force-pushed
the
mqtt_broadcaster
branch
6 times, most recently
from
July 4, 2023 17:07
6e4e21c
to
5436f0f
Compare
jbbjarnason
reviewed
Jul 5, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I would suggest making unit tests for each part of the code, but this probably covers the use cases but it is hard to read through the tests.
magni-mar
force-pushed
the
mqtt_broadcaster
branch
2 times, most recently
from
July 5, 2023 16:29
c713ed8
to
4afdf30
Compare
Closing this PR because more features need to be added to the executable until it can be merged, such as SparkPlug B and more. |
omarhogni
force-pushed
the
mqtt_broadcaster
branch
from
July 14, 2023 10:11
5c09a53
to
e52ec19
Compare
omarhogni
force-pushed
the
mqtt_broadcaster
branch
from
July 14, 2023 10:12
704cb56
to
caa39f0
Compare
omarhogni
force-pushed
the
mqtt_broadcaster
branch
from
July 14, 2023 10:17
41d3b45
to
7c46c98
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.