reuse elasticsearch client and properly close it on error

fixes cloudflarearchive#21
Sixt · Oct 8, 2020 · bcf891f · bcf891f
1 parent 493cdb2
commit bcf891f
Showing 1 changed file with 13 additions and 1 deletion.
diff --git a/aws/src/main/java/com/cloudflare/elastic/ElasticLambdaForwarder.java b/aws/src/main/java/com/cloudflare/elastic/ElasticLambdaForwarder.java
@@ -89,6 +89,7 @@ public class ElasticLambdaForwarder implements RequestHandler<S3Event, Void>
     private static boolean ELASTIC_DEBUG       = false;
     private static boolean USE_AWS_CREDENTIALS = false;
 
+    RestHighLevelClient es;
 
     @Override
     public Void handleRequest(S3Event event, Context context)
@@ -102,7 +103,9 @@ public Void handleRequest(S3Event event, Context context)
                     "Parameters: hostname [%s:%d] index [%s], username [%s], pipeline [%s], ssl/tls [%b]",
                     ELASTIC_HOSTNAME, ELASTIC_PORT, ELASTIC_INDEX, ELASTIC_USERNAME, ELASTIC_PIPELINE, ELASTIC_HTTPS));
 
-            RestHighLevelClient es = client(ELASTIC_HOSTNAME, ELASTIC_PORT, ELASTIC_USERNAME, ELASTIC_PASSWORD, ELASTIC_HTTPS);
+            if (es == null) {
+                es = client(ELASTIC_HOSTNAME, ELASTIC_PORT, ELASTIC_USERNAME, ELASTIC_PASSWORD, ELASTIC_HTTPS);
+            }
 
             AmazonS3 s3Client = getS3Client();
             BulkProcessor processor = processor(es, BULK_ACTIONS, BULK_CONCURRENCY);
@@ -119,6 +122,15 @@ public Void handleRequest(S3Event event, Context context)
         }
         catch (Exception e) {
             logger.log(String.format("%s\n%s", e.getMessage(), trace(e)));
+            try {
+                if (es != null) {
+                    es.close();
+                }
+            } catch (IOException ignored) {
+
+            } finally {
+                es = null;
+            }
         }
 
         return null;