Combine tree edit #191
Combine tree edit #191
Conversation
…editor wraps a tree)
…ssfully handled independently of the activate editor event
If the editor wraps a tree, and you edit a child node, then when editing is complete it renders with the correct level of indentation. To do this I had to make sure that the options object used to render original child is used at the end of the edit.
…an editor widget is invoked. Both the row data object and the widget are passed
Conflicts: tree.js - resolved by using upstream version
key won't try to expand tree. Make sure 'this' points to column object when calling originalRenderCell from editor (so that tree can see correct version of this).
|
Thanks for this pull request! I actually had been in progress of working on this from the opposite angle (wrapping tree around editor) and just committed that; however, I saw a couple of other ideas in here that might also be useful in the future. I would say I'm a bit concerned at the approach here which seems to put some amount of tree-specific logic within the editor module; such conflation of concerns was something I tried to avoid. However, it'd certainly be ideal if both directions can eventually be supported. |
No problem - I'll check out your changes soon. I'm not precious about my code so feel free to close this pull request if you don't need the code. I'd rather use the upstream version than maintain my own.
I was concerned about that too. It felt wrong to wrap the tree in an editor rather than vice-versa, but I started off with that and I was in a hurry so I kept going with it. |
I've edited dgrid so that it's possible to to combine tree and editor. For it to work, the editor has to wrap a tree, e.g. editor(tree(column)).
I haven't added any test code nor updated any of the docs, and I've only tested it against my own specific case where the tree is only 1 level deep.