feat: added prop to allow target's default behaviour #468
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added prop allowTargetInteraction which will allow target's default behaviour
pawanbangar
changed the title
pawanbangar
changed the title
Updated docs for interactive Target
Disabling onTargetDoubleTap, onTargetLongPress and onTargetClick if you pass allowTargetInteraction
|
@pawanbangar I am closing this PR as per the comment I did on issue #467. Please ping me if you believe this is still necessary. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
added prop allowTargetInteraction which will allow target's default behaviour
Description
Currently we are not allowed to make target interactive, because positioned widget is drawn on top of overlay, this PR will remove that positioned widget, then user won't able to use onClick on target, this is not a breaking change
allowTargetInteractionwill handle this via removing that widget if passed as trueChecklist
fix:,feat:,docs:etc).docsand added dartdoc comments with///.examplesordocs.Breaking Change?
Related Issues
Closes #467 (comment) and
#465 (comment)