Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: 🐛 Fixed target hit area #409

Merged
merged 1 commit into from
Mar 7, 2024
Merged

Conversation

Sahil-Simform
Copy link
Collaborator

@Sahil-Simform Sahil-Simform commented Mar 6, 2024

  • Updated IgnorePointer to AbsorbPointer as ignore pointer is not blocking tap to descendants
  • removed FractionalTranslation as it is not shifting tappable area and only shifting paint of widgets
  • Made size and shapeBorder not nullable as we are assigning not null values to that constructor variable
  • Updated default offset to rectBound.topLeft

Description

Checklist

  • The title of my PR starts with a Conventional Commit prefix (fix:, feat:, docs: etc).
  • I have followed the Contributor Guide when preparing my PR.
  • I have updated/added tests for ALL new/updated/fixed functionality.
  • I have updated/added relevant documentation in docs and added dartdoc comments with ///.
  • I have updated/added relevant examples in examples or docs.

Breaking Change?

  • Yes, this PR is a breaking change.
  • No, this PR is not a breaking change.

- Updated `IgnorePointer` to `AbsorbPointer` as ignore pointer is not blocking tap to descendants
- removed `FractionalTranslation` as it is not shifting tappable area and only shifting paint of widgets
- Made `size` and `shapeBorder` not nullable as we are assigning not null values to that constructor variable
- Updated default `offset` to `rectBound.topLeft`
@aditya-css aditya-css merged commit 3623642 into master Mar 7, 2024
4 checks passed
@aditya-css aditya-css deleted the bugFix/target_hit_area_fix branch March 7, 2024 05:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants