fix: ⚡ Optimize GetPosition class
#370
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aditya-css
requested changes
Mar 6, 2024
lib/src/get_position.dart
Outdated
|
|
||
| void getRenderBox() { | ||
| var renderBox = key.currentContext?.findRenderObject() as RenderBox?; | ||
| if (renderBox != null) { |
There was a problem hiding this comment.
Please invert the condition and return.
lib/src/get_position.dart
Outdated
| Rect getRect() { | ||
| if (_box == null || | ||
| _boxOffset == null || | ||
| (_boxOffset?.dx.isNaN ?? true) || |
There was a problem hiding this comment.
Please create an extension for this.
lib/src/get_position.dart
Outdated
| if (boxOffset.dy.isNaN) return 0 - padding.top; | ||
| final topLeft = box.size.topLeft(boxOffset); | ||
| if (_box == null || _boxOffset == null || (_boxOffset?.dy.isNaN ?? true)) { | ||
| return 0 - padding.top; |
There was a problem hiding this comment.
I believe you can skip subtracting from 0 and directly assign negative sign here.
Sahil-Simform
force-pushed
the
bugFix/improve_get_position_class
branch
2 times, most recently
from
36ea121
to
2f9ab68
Compare
Sahil-Simform
force-pushed
the
bugFix/improve_get_position_class
branch
from
2f9ab68
to
1edfcf9
Compare
aditya-css
approved these changes
Mar 6, 2024
|
When will this be released? I need the fix and therefore have to use master right now, it would be nice to be able to switch back to the pub version. |
|
Hey @guenth39, We would like to inform that we have released this commit with 2.1.0 version of this package. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Reduced call for render object. Improved conditions.
Checklist
fix:,feat:,docs:etc).docsand added dartdoc comments with///.examplesordocs.Breaking Change?
Related Issues
None.