Add python-version file #1816
Add python-version file #1816
Conversation
|
This PR does three unrelated things and only one of them is in the PR title and makes it to release notes. Could you please create three PRs? @panaaj did we have something specific why we pinned the mdbook image version? I have a vague recollection there was something. anyway: i would rather re-pin it to avoid it spontaneously combusting in the future. We have already switched doc generator at least once, here longevity trumps freshness imho. Aaaand notice how the discussion on another topic keeps me from merging the python addition when they are in the same pr… |
|
YES! Fair ... I will do that right now. |
Python 3.12 doesn't work for building node-sass due to the removal of distutils, but 3.11 does. For people using pyenv (similar to nvm) we can set a python version. This won't solve build mismatches for everyone, but node v20 + python 3.11 does work, so might as well capture it.
emonty
force-pushed
the
random-build-tweaks
branch
from
44cd01f
to
f6233e1
Compare
I don't recall why the specific version was used.... I know when I originally set the doc up a specific version wasn't used but it may have been required when setting up the build pipeline. |
The current Dockerfile builds with node v20, while the .nvmrc file in the repo lists v16, which is fairly old and supported less and less. Bump the nvmrc to match the containers being built. Also, python 3.12 does not work to build node-sass due to the removal of distutils. For people using pyenv, which is similar to nvm but for python, add a .python-version file listing 3.11 which will allow npm install to run.
Finally, remove the mdbook version pin. The current version works, while the version listed in the pin does not support multi-arch images (such as Macbooks with ARM processors)