Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: Error message when logging in is shown properly #1582

Merged
merged 1 commit into from
Jul 18, 2023

Conversation

JacoKoster
Copy link
Contributor

Instead of showing a stringified version of the json response, we show the message instead.

@JacoKoster
Copy link
Contributor Author

Probably a silly request, but it shows in this PR. The prettier standard of 80 columns feels a bit too short, what do we think of changing this to 100?

@tkurki tkurki added the fix label Jul 18, 2023
@tkurki
Copy link
Member

tkurki commented Jul 18, 2023

I'm in the "go with the least prettier config" camp, but am pretty ambivalent about line length. Since I recently learned about https://www.stefanjudis.com/today-i-learned/how-to-exclude-commits-from-git-blame/ my earlier objection about noise in diffs is less revelant, if not quite nonexistent.

@tkurki tkurki merged commit df9ceb2 into SignalK:master Jul 18, 2023
2 of 3 checks passed
@JacoKoster
Copy link
Contributor Author

As i am usually working on a wide screen, i pretty much always find that the 80 columns works counter intuitively of the goal of making the lines more readable. For now i'll stick with the default :)

@JacoKoster JacoKoster deleted the fix-error-message branch September 9, 2023 18:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants