This repository has been archived by the owner on Jul 27, 2024. It is now read-only.
Centralize Ruby Version to .ruby-version
#758
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jenshenny
force-pushed
the
centralize_ruby_version
branch
from
40a93c7
to
eb7d467
Compare
add a .ruby-version file and remove reference in dev.yml
jenshenny
force-pushed
the
centralize_ruby_version
branch
from
eb7d467
to
c18c9b7
Compare
TargetRubyVersion will read from required_ruby_version in Rubocop 1.61+
jenshenny
force-pushed
the
centralize_ruby_version
branch
from
c18c9b7
to
06943ea
Compare
|
The CI failures look unrelated to the changes (CI fails on main at the moment https://github.com/Shopify/theme-check/actions/runs/8904032322/job/24453139188). @karreiro @mgmanzella would you or your team be able to push this along? |
karreiro
reviewed
May 1, 2024
There was a problem hiding this comment.
Thank you for this PR, @jenshenny!
We are planning to archive this repository very soon in favor of https://github.com/shopify/theme-tools, so I believe we may close this PR.
Please feel free to ping me on Slack if you need any extra details about the timeline :)
|
Ah gotcha! Thanks for letting me know @karreiro - I'll close this off :) |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What are you trying to accomplish?
The
.ruby-versionfile is the ecosystem standard for defining a Ruby version. This PR adds the.ruby-versionfile, ensures arequired_ruby_versionis set, and removes all other references to Ruby in this repository, aligning it with the standard.What should reviewers focus on?
Important
Please verify the following before merging:
Verify that the changes in the PR meets the following requirements or adjust manually to make it compliant:
.ruby-versionfile is present with the correct Ruby version definedrequired_ruby_versionin your gemspec is setdev.ymlRuby task (before:- ruby: x.x.x, after:- ruby)Gemfile(no lines withruby <some-version>)Gemfile.lockis built with the defined Ruby versionTargetRubyVersiondefined inrubocop.yml(reads fromrequired_ruby_versionon Rubocop 1.61.0)ruby/setup-rubyGithub Actions that do not run on a Ruby matrix (no lines withruby-version: “x.x”)To establish consistency, the
required_ruby_versionis set to 2.7. If you think that another version is a better fit, please make the applicable changes.Please ensure passing CI and merge this PR if it looks good, this PR will be addressed if there isn't any activity after 4 weeks.