Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Retry on Zlib::BufError #83

Merged
merged 2 commits into from
Jan 17, 2024
Merged

Retry on Zlib::BufError #83

merged 2 commits into from
Jan 17, 2024

Conversation

ianks
Copy link

@ianks ianks commented Jan 16, 2024

This error happens sporadically for currently unknown reasons. I fixed one race condition in ruby/zlib#74, but we are still getting tons of errors even with that patch. For now, the best solution is to retry once, knowing probability is on our side (a la opal/opal#2463).

@ianks ianks requested a review from a team as a code owner January 16, 2024 20:12
@ianks ianks requested a review from gmalette January 16, 2024 20:15
Copy link

@gmalette gmalette left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

😭

@ianks ianks merged commit 4290b43 into main Jan 17, 2024
11 checks passed
@ianks ianks deleted the retry-on-zlib-buferror branch January 17, 2024 02:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants