-
Notifications
You must be signed in to change notification settings - Fork 50
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update action to Shopify CLI 3, lhci 0.13 and ruby 3.2 #77
Conversation
18a0026
to
94885a4
Compare
08aa4ce
to
777f280
Compare
aea05e7
to
754af0b
Compare
754af0b
to
91a144b
Compare
@jamesmengo was 3.1.4 not working then? I have tried it on a fork here but couldn't get it working. Haven't tried 3.2.0 though |
Nokogiri seems to be a dependency of shopify-cli 2x, not theme-check. I believe that bumping the ruby env on the lighthouse repo is not actually getting it fixed. I have tried it myself as well. I believe the issue is here, where shopify-cli uses Nokogiri 1.13 whereas we need 1.15 or above. So basically the Shopify-cli needs to bump nokogiri dependency version. Hope this helps |
f4d97da
to
957eccd
Compare
You're correct that Nokogiri is a dependancy of shopify-cli, but from my understanding the version causing an issue isn't coming from there, it's coming from
|
4359cd8
to
22b6525
Compare
ec17b6e
to
a66caae
Compare
a66caae
to
5418e27
Compare
Bump installed Ruby Version to 3.2.0 to satisfy
Nokigiri
dependancy (more context in issue)Ruby Maintenance Branches
Why did this happen?
Nokogiri
is included as a dependancy viashopify-theme-check
, so this started to break since the latest release ended support for Ruby 2.7We could consider freezing the version in the gemspec for theme_check, but that would come with the tradeoff of not receiving future updates
Why Version 3.2.0?
Nokigiri
requires > version3.0.0
, but3.0.0
is approaching EOL in March 2024Validating this change
CI
workflow results here- We execute this action on PRs in this repo so that we can validate behaviour
More notes