[WIP] Batch Trade Position Units Bugfix #121
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit c67ffa0.
* update code comments in set token api + protocol viewer to reflect correct param usage * add null address constant * update validate quotes method to be more generalized * check batch trade does not produce dust positions on utils api layer * update trade quoter to use BigNumber instead of decimal * update validation helper to allow only checking from token quantities option * refactor conversion of tokens from and to pre token positions into helper method * remove remaining comments for checking dust positions * correctly use current token position if max implied + zero ex match * only validate batch trade does not produce dust positions for tokens spread across multiple trades * add more clarity to comments * add comment re: max selling across multiple trades
…rotocol/set.js into chris/batch-trade-extension
…only need to apply it to the first trade for agiven from component in a batch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.