TradeModuleV2 and GeneralIndexModuleV2 #154
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
richardliang
changed the title
|
Commenting the diff for TradeModule and GeneralIndexModule |
bweick
reviewed
Oct 22, 2021
| internal | ||
| returns (uint256 protocolFee, uint256 managerRebate) | ||
| { | ||
| uint256 totalFeePercentage = controller.getModuleFee(address(this), TRADE_MODULE_V2_TOTAL_FEE_INDEX); |
There was a problem hiding this comment.
Why not use:
uint256 totalFees = getModuleFee(TRADE_MODULE_PROTOCOL_FEE_INDEX, _exchangedQuantity);
managerRebate = controller.getModuleFee(address(this), TRADE_MODULE_V2_MANAGER_REBATE_SPLIT_INDEX).preciseMul(totalFees);
protocolFee = totalFees.sub(managerRebate);
I think that way you can be more confident about not having some extra wei sent out due to rounding and you aren't recalculating totalFeePercentage.preciseMul(_exchangedQuantity)
bweick
reviewed
Oct 22, 2021
| * @param _setToken Instance of the SetToken to update fee recipient | ||
| * @param _newRebateRecipient New rebate fee recipient address | ||
| */ | ||
| function updateFeeRecipient( |
There was a problem hiding this comment.
Maybe make this clearer and call it updateRebateRecipient
bweick
reviewed
Oct 22, 2021
| * @param _setToken Instance of the SetToken to update fee recipient | ||
| * @param _newRebateRecipient New rebate fee recipient address | ||
| */ | ||
| function updateFeeRecipient( |
There was a problem hiding this comment.
Would call this updateRebateRecipient as well
bweick
reviewed
Oct 22, 2021
| uint256 totalFeePercentage = controller.getModuleFee(address(this), GENERAL_INDEX_MODULE_V2_TOTAL_FEE_INDEX); | ||
| uint256 managerRebateSplitPercentage = controller.getModuleFee(address(this), GENERAL_INDEX_MODULE_V2_MANAGER_REBATE_SPLIT_INDEX); | ||
|
|
||
| managerRebate = totalFeePercentage.preciseMul(exchangedQuantity).preciseMul(managerRebateSplitPercentage); |
There was a problem hiding this comment.
Would change this math similarly to TradeModuleV2 comment
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Code Review Processes
New Feature Review
Before submitting a pull request for new review, make sure the following is done:
README Checks
Code Checks
Broader Considerations