Checkpoint 1 for revamped ExchangeIssuance. #13
Conversation
| - May be issues with on-going compatibility since adapters are built more for modules | ||
| - May require additional contracts/code to turn standardized data inputs into a function call to the adapter | ||
|
|
||
| ### Option 2: Use 0x-like implementation |
There was a problem hiding this comment.
One potential problem with this implementation is when a set contains wrapped tokens. At the time of submitting a transaction, a set may contain 1.001 DAI worth of cDAI. However, by the time the transaction is mined, the exchange rate will have likely increased, making minting the set require 1.002 DAI worth of cDAI.
Since all trades and transformations would be computed off-chain, this solution would only purchase 1.001 DAI, and would then revert when attempting to wrap it into the correct about of cDAI.
| This feature should be able to handle the following asset types: | ||
| - Spot tokens | ||
| - Wrapped tokens (AAVE, Compound) | ||
| - LP tokens (Curve, UniswapV2, Sushiswap) |
There was a problem hiding this comment.
LP tokens have a special problem of often not having the ability to create a trade with a specified output amount of LP tokens. Instead, they usually require supplying an input amount of the underlying tokens. This setup is incompatible with the issuance modules which would require fixed proportions of each token (including the LP tokens). Have you thought of any potential solutions for this?
No description provided.