Config nextjs #162
Open
Config nextjs #162
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jkisiolek
suggested changes
Jun 24, 2022
typeWolffo
requested changes
Jun 24, 2022
kPoziomek
force-pushed
the
config-nextjs
branch
3 times, most recently
from
7e859f1
to
755b1c5
Compare
jkisiolek
reviewed
Jun 27, 2022
kPoziomek
force-pushed
the
config-nextjs
branch
3 times, most recently
from
d214733
to
eaf21bf
Compare
typeWolffo
approved these changes
Jul 1, 2022
jkisiolek
reviewed
Jul 1, 2022
frontend/pages/index.js
Outdated
| <meta property="og:description" content={description} /> | ||
| <meta | ||
| property="og:image" | ||
| content={`../public/assets/images/logo.svg`} |
There was a problem hiding this comment.
Suggested change
| content={`../public/assets/images/logo.svg`} | |
| content="../public/assets/images/logo.svg" |
frontend/src/__tests__/components/__snapshots__/PostContent.test.js.snap
Show resolved
Hide resolved
jkisiolek
approved these changes
Jul 4, 2022
qbart
reviewed
Jul 4, 2022
| @@ -1,5 +1,5 @@ | |||
| import { rest } from 'msw' | |||
| import { Post } from './mocks/post.mock' | |||
| import { Post } from './__mocks__/post.mock' | |||
|
|
|||
| export const apiUrl = process.env.REACT_APP_API_URL | |||
There was a problem hiding this comment.
should we change that to NEXT_PUBLIC_API_URL?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.