Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add ecr module with example #9

Merged
merged 5 commits into from
Jun 11, 2024
Merged

add ecr module with example #9

merged 5 commits into from
Jun 11, 2024

Conversation

Jlkan
Copy link
Contributor

@Jlkan Jlkan commented Jun 10, 2024

No description provided.

@Jlkan Jlkan requested a review from qbart June 10, 2024 13:58
qbart
qbart requested changes Jun 10, 2024
View reviewed changes
Copy link
Member

@qbart qbart left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

check the files, seems we have a duplicated

modules/ecr-repository/versions.tf Outdated Show resolved Hide resolved
modules/ecr-repository/lifecycle.json Outdated Show resolved Hide resolved
@Jlkan Jlkan requested a review from qbart June 11, 2024 10:36
@qbart qbart merged commit d0aef5e into main Jun 11, 2024
1 of 2 checks passed
@qbart qbart deleted the feat/ecr branch June 11, 2024 11:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@qbart qbart qbart approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Jlkan @qbart