Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update branding #3

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

update branding #3

wants to merge 1 commit into from

Conversation

michalgren
Copy link

I have updated the primary logo and added new logo files that we are currently using.

@michalgren michalgren self-assigned this Feb 28, 2023
Copy link
Member

@ArekJanik ArekJanik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There's an issue with the shape, I think on all logos:
Screenshot 2023-02-28 at 10 00 00

Also we could compress the logos, svgomg on precision 2 gives quite a big change on signet: 5.27k → 1.85k 35.12%

@@ -0,0 +1,4 @@
<svg width="103" height="114" viewBox="0 0 103 114" fill="none" xmlns="http://www.w3.org/2000/svg">
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just wondering, maybe it would be better to export it as a square? Or add the square viewBox as another variant.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I checked that on my software because sometimes vector rendering is broken but the shape is actually ok, but this one seem broken

@rafalbromirski
Copy link
Contributor

Nice. Finally an update :D

Copy link
Member

@qbart qbart left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

make sure logos don't have artifacts

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants